[Feature/album detail] bottomSheet와 사진 디테일 추가 #85

kez-lab · 2023-07-06T16:10:22Z

close Album Detail 화면 생성 #59

[feat/album_detail]: Add Album Detail [feat/album_detail]: Add Bottom Sheet [feat/album_detail]: bottomSheet 이슈 발생 [feat/album_detail]: AlbumDetailActivity 이동 추가 [feat/album_detail]: AlbumDetail Delete Dialog 추가 [feat/album_detail]: AlbumList refactor and PhotoId Int To Long [feat/album_detail]: AlbumList, Album Detail 세부내용 추가

l2hyunwoo · 2023-07-06T16:31:46Z

app/src/main/res/values/type.xml

+    <style name="TextAppearance.Pophory.HeadLine02">
+        <item name="android:textFontWeight">600</item>
+        <item name="android:textSize">19sp</item>
+        <item name="lineHeight">17sp</item>
+    </style>
+


l2hyunwoo · 2023-07-06T16:33:06Z

app/src/main/res/values/themes.xml

@@ -33,6 +33,7 @@
        <item name="textAppearanceHeadlineMedium">@style/TextAppearance.Pophory.HeadLineMedium
        </item>
        <item name="textAppearanceHeadlineSmall">@style/TextAppearance.Pophory.HeadLineSmall</item>
+        <item name="textAppearanceHeadline2">@style/TextAppearance.Pophory.HeadLine02</item>


textAppearanceHeadlineLarge로 사용하시면 될듯

l2hyunwoo · 2023-07-06T16:33:24Z

app/src/main/res/layout/modal_bottom_sheet_content.xml

+        android:paddingStart="20dp"
+        android:paddingEnd="0dp"
+        android:text="@string/sort_oldest"
+        android:textAppearance="@style/TextAppearance.Pophory.ModalText2"


Suggested change

android:textAppearance="@style/TextAppearance.Pophory.ModalText2"

android:textAppearance="?textAppearanceHeadlineMedium"

l2hyunwoo · 2023-07-06T16:34:02Z

app/src/main/res/layout/modal_bottom_sheet_content.xml

+        android:layout_height="wrap_content"
+        android:layout_marginStart="20dp"
+        android:text="@string/select_sort"
+        android:textAppearance="@style/TextAppearance.Pophory.ModalText1"


Suggested change

android:textAppearance="@style/TextAppearance.Pophory.ModalText1"

android:textAppearance="?textAppearanceModalText1"

l2hyunwoo · 2023-07-07T01:41:41Z

app/src/main/java/com/teampophory/pophory/feature/album/list/AlbumListActivity.kt

@@ -76,6 +83,17 @@ class AlbumListActivity : AppCompatActivity() {
    }

    private fun initSortViews() {
+        viewModel.albumSortType.flowWithLifecycle(lifecycle, Lifecycle.State.STARTED).onEach {


Suggested change

viewModel.albumSortType.flowWithLifecycle(lifecycle, Lifecycle.State.STARTED).onEach {

viewModel.albumSortType.flowWithLifecycle(lifecycle).onEach {

그냥 이렇게 해도 되지 않나?

@l2hyunwoo
기본값이 있군요 확인!!

@OptIn(ExperimentalCoroutinesApi::class) public fun <T> Flow<T>.flowWithLifecycle( lifecycle: Lifecycle, minActiveState: Lifecycle.State = Lifecycle.State.STARTED ): Flow<T> = callbackFlow { lifecycle.repeatOnLifecycle(minActiveState) { [email protected] { send(it) } } close() }

l2hyunwoo · 2023-07-07T01:42:16Z

app/src/main/java/com/teampophory/pophory/feature/album/list/AlbumListActivity.kt

+        viewModel.albumSortType.flowWithLifecycle(lifecycle, Lifecycle.State.STARTED).onEach {
+            binding.tvSort.text =  when(it) {
+                AlbumSortType.NEWEST -> {
+                    getString(R.string.sort_newest)


유틸에 stringOf라고 있지 않나?

오 처음봤슴다

librarywon

LGTM... 의진아 넌 정말 체고다 ✨ ✨ ✨ ✨ ✨ ✨

librarywon · 2023-07-07T03:00:52Z

app/src/main/java/com/teampophory/pophory/data/network/model/album/PhotoListResponse.kt

+            when {
+                (width > height) -> {
+                    photoDetails.add(
+                        PhotoDetail(id, studio, takenAt, imageUrl, width, height, OrientType.HORIZONTAL)
+                    )
+                }
+                (width < height) -> {
+                    photoDetails.add(
+                        PhotoDetail(id, studio, takenAt, imageUrl, width, height, OrientType.VERTICAL)
+                    )
+                }
+                else -> {
+                    photoDetails.add(
+                        PhotoDetail(id, studio, takenAt, imageUrl, width, height, OrientType.NONE)
+                    )
+                }
+            }


이렇게 해보는건 어떤가요?

Suggested change

when {

(width > height) -> {

photoDetails.add(

PhotoDetail(id, studio, takenAt, imageUrl, width, height, OrientType.HORIZONTAL)

)

}

(width < height) -> {

photoDetails.add(

PhotoDetail(id, studio, takenAt, imageUrl, width, height, OrientType.VERTICAL)

)

}

else -> {

photoDetails.add(

PhotoDetail(id, studio, takenAt, imageUrl, width, height, OrientType.NONE)

)

}

}

val orientationType = when {

width > height -> OrientType.HORIZONTAL

width < height -> OrientType.VERTICAL

else -> OrientType.NONE

}

photoDetails.add(

PhotoDetail(id, studio, takenAt, imageUrl, width, height, orientationType)

)

개쩔어요 지렸다...

여기에 또 제가 간과한 부분이 == 일 경우에는 NONE으로 처리되게 해놓았네욥... 해당 부분도 수정해서 처리하도록 하겠습니다

librarywon · 2023-07-07T03:07:19Z

app/src/main/java/com/teampophory/pophory/feature/album/detail/AlbumDeleteDialogFragment.kt

+    }
+
+    companion object {
+        @JvmStatic


이 어노테이션은 어떤 역할을 하나요?

자바에서도 static처럼 사용할 수 있게 해주는 친구입니당

오 또 배워가네요 감사합니다 ㅎㅎ

librarywon · 2023-07-07T03:10:15Z

app/src/main/java/com/teampophory/pophory/feature/album/list/AlbumListActivity.kt

+                    Timber.tag(TAG).d("initObserver: %s", albumState.data)
+                }
+
+                is AlbumListState.Error -> {


이렇게 테그를 활용하는거군요 배웠습니다!

저도... 잘 모르는데 코파일럿이 추천해주었어요 ㅋㅎㅋㅎㅎㅋㅎㅋㅎ

librarywon · 2023-07-07T03:11:49Z

app/src/main/java/com/teampophory/pophory/feature/album/list/viewholder/AlbumViewHolder.kt

+        }
+        private fun ImageView.loadAndDisplayHorizontalImage(photoDetail: PhotoDetail) =
+            load(photoDetail.imageUrl) {
+                crossfade(true)


coil 실망할뻔 휴~~

coil 컨트리뷰트 한번 가시죠

kez-lab added 😼곽의진 곽의진이 했다 ✨ Feature 기능 개발 labels Jul 6, 2023

kez-lab requested a review from a team as a code owner July 6, 2023 16:10

kez-lab self-assigned this Jul 6, 2023

kez-lab force-pushed the feature/album_detail branch from 7a5f89f to 8027845 Compare July 6, 2023 16:12

kez-lab added 2 commits July 7, 2023 01:12

[feat/album_detail]: rebase and sync develop

c68dbd4

kez-lab force-pushed the feature/album_detail branch from 8027845 to c68dbd4 Compare July 6, 2023 16:20

[feat/album_detail]: add ignore

cd7bffc

l2hyunwoo requested changes Jul 6, 2023

View reviewed changes

kez-lab added 3 commits July 7, 2023 05:34

[feat/album_detail]: issue finish

f2b8740

[feat/album_detail]: 기본이미지 선택 금지

6be1aeb

[feat/album_detail]: 정렬 텍스트 추가

405b28e

l2hyunwoo reviewed Jul 7, 2023

View reviewed changes

librarywon approved these changes Jul 7, 2023

View reviewed changes

[feat/album_detail]: PR 대응

e864a7e

kez-lab closed this Jul 7, 2023

kez-lab deleted the feature/album_detail branch July 7, 2023 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature/album detail] bottomSheet와 사진 디테일 추가 #85

[Feature/album detail] bottomSheet와 사진 디테일 추가 #85

kez-lab commented Jul 6, 2023

l2hyunwoo Jul 6, 2023

l2hyunwoo Jul 6, 2023

l2hyunwoo Jul 6, 2023

l2hyunwoo Jul 6, 2023

l2hyunwoo Jul 7, 2023

kez-lab Jul 7, 2023

l2hyunwoo Jul 7, 2023

kez-lab Jul 7, 2023

librarywon left a comment

librarywon Jul 7, 2023

kez-lab Jul 7, 2023

kez-lab Jul 7, 2023

librarywon Jul 7, 2023

kez-lab Jul 7, 2023

librarywon Jul 7, 2023

librarywon Jul 7, 2023

kez-lab Jul 7, 2023

librarywon Jul 7, 2023

kez-lab Jul 7, 2023

	android:textAppearance="@style/TextAppearance.Pophory.ModalText2"
	android:textAppearance="?textAppearanceHeadlineMedium"

	android:textAppearance="@style/TextAppearance.Pophory.ModalText1"
	android:textAppearance="?textAppearanceModalText1"

	viewModel.albumSortType.flowWithLifecycle(lifecycle, Lifecycle.State.STARTED).onEach {
	viewModel.albumSortType.flowWithLifecycle(lifecycle).onEach {

[Feature/album detail] bottomSheet와 사진 디테일 추가 #85

[Feature/album detail] bottomSheet와 사진 디테일 추가 #85

Conversation

kez-lab commented Jul 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

librarywon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment