Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/logout-withdrawal] 설정화면 서버통신까지 기능 구현 완료 #80

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

l2hyunwoo
Copy link
Member

No description provided.

@l2hyunwoo l2hyunwoo added 🐯 이현우 이현우가 했다 ✨ Feature 기능 개발 labels Jul 6, 2023
@l2hyunwoo l2hyunwoo requested a review from a team as a code owner July 6, 2023 01:04
@l2hyunwoo l2hyunwoo self-assigned this Jul 6, 2023
Copy link
Member

@kez-lab kez-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeatOnLifeCycler관련 부분만 확인해주시고 머지 부탁드립니다~!!
LGTM 🔫

Comment on lines +80 to +85
repeatOnLifecycle(Lifecycle.State.STARTED) {
runCatching {
kakaoAuthService.logout()
}.onSuccess {
viewModel.logout()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STOP -> STARTED 상황에서 로직이 반복될 때 이슈는 없었을까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 테스트 해본 결과 문제 없었습니다.

Comment on lines +22 to +26
private val _message = MutableSharedFlow<String>()
val message = _message.asSharedFlow()

private val _event = MutableSharedFlow<Event>()
val event = _event.asSharedFlow()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SharedFlow 사용 아주 멋집니다~!!

@l2hyunwoo l2hyunwoo merged commit 3a5ea4a into develop Jul 6, 2023
1 check passed
@l2hyunwoo l2hyunwoo deleted the feature/logout-withdrawal branch July 6, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 🐯 이현우 이현우가 했다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants