-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/logout-withdrawal] 설정화면 서버통신까지 기능 구현 완료 #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repeatOnLifeCycler관련 부분만 확인해주시고 머지 부탁드립니다~!!
LGTM 🔫
repeatOnLifecycle(Lifecycle.State.STARTED) { | ||
runCatching { | ||
kakaoAuthService.logout() | ||
}.onSuccess { | ||
viewModel.logout() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STOP -> STARTED 상황에서 로직이 반복될 때 이슈는 없었을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 테스트 해본 결과 문제 없었습니다.
private val _message = MutableSharedFlow<String>() | ||
val message = _message.asSharedFlow() | ||
|
||
private val _event = MutableSharedFlow<Event>() | ||
val event = _event.asSharedFlow() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SharedFlow 사용 아주 멋집니다~!!
No description provided.