[Feature/home_network] home/store, home/mypage 네트워크 작업 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librarywon
force-pushed
the
feature/home_network
branch
from
11a6971
to
62afdf0
Compare
l2hyunwoo
approved these changes
Jul 6, 2023
app/src/main/AndroidManifest.xml
Outdated
| @@ -64,7 +64,7 @@ | |||
| android:exported="false" /> | |||
| <activity | |||
| android:name=".feature.home.HomeActivity" | |||
| android:exported="false" /> | |||
| android:exported="true" /> | |||
| @@ -54,6 +55,7 @@ object NetModule { | |||
| ): OkHttpClient = OkHttpClient.Builder() | |||
| .addInterceptor(logInterceptor) | |||
| .addInterceptor(authInterceptor) | |||
| .apply { FlipperInitializer.initOkHttpClient(this) } | |||
| override suspend fun getMyPageInfo(): Result<MyPageResponse> { | ||
| return runCatching { retrofitMyPageNetwork.getMyPages() } | ||
| } | ||
|
|
Comment on lines
73
to
75
| val intent = Intent(context, AlbumListActivity::class.java).apply { | ||
| putExtra("albumId", albumItem.id) | ||
| } |
There was a problem hiding this comment.
이거 AlbumListActivity내의 로직으로 전환하는게 좋을듯 cc. @KwakEuiJin
There was a problem hiding this comment.
그럼 일단 �인텐트로 엑티비티 전환처리만 해두겠습니다
|
|
||
| binding.viewpagerStore.adapter = adapter | ||
| private fun setupViewPager() { | ||
| storeAdapter = StoreAdapter({ albumItem -> |
| storeAdapter?.submitList(storeState.data) | ||
|
|
||
| //최초 데이터 세팅 | ||
| binding.tvStoreAlbumPhotoCount.text = storeState.data[0].photoCount.toString() + "/30" |
There was a problem hiding this comment.
Suggested change
| binding.tvStoreAlbumPhotoCount.text = storeState.data[0].photoCount.toString() + "/30" | |
| binding.tvStoreAlbumPhotoCount.text = storeState.data.firstOrNull().photoCount.toString() + "/30" |
+) 앨범 없을때의 로직도 추가해야할듯
There was a problem hiding this comment.
아래 onPageChanged 콜백하고 동일 로직인 것 같은데 확인해보실?
There was a problem hiding this comment.
확인해보니 맞습니다 수정반영 했습니다!
| val text = buildSpannedString { | ||
| color(colorOf(R.color.pophory_purple)) { | ||
| textAppearance(requireContext(), R.style.TextAppearance_Pophory_HeadLineBold) { | ||
| append("포포리 앨범") |
There was a problem hiding this comment.
Suggested change
| append("포포리 앨범") | |
| append(coloredText) |
Comment on lines
44
to
49
| interface OnPageChangedListener { | ||
| fun onPageChanged(albumItem: AlbumItem) | ||
| } |
There was a problem hiding this comment.
Suggested change
| interface OnPageChangedListener { | |
| fun onPageChanged(albumItem: AlbumItem) | |
| } | |
| fun interface OnPageChangedListener { | |
| fun onPageChanged(albumItem: AlbumItem) | |
| } |
| ) | ||
| } | ||
| } | ||
|
|
librarywon
force-pushed
the
feature/home_network
branch
from
1f58ecd
to
96367a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 코드
📸 스크린샷
🍀 관련 이슈