Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

회원가입쪽 Refactoring #71

Merged
merged 1 commit into from
Jul 5, 2023
Merged

회원가입쪽 Refactoring #71

merged 1 commit into from
Jul 5, 2023

Conversation

l2hyunwoo
Copy link
Member

No description provided.

@l2hyunwoo l2hyunwoo added 🐯 이현우 이현우가 했다 🔨 Refactor 코드 리팩토링 labels Jul 5, 2023
@l2hyunwoo l2hyunwoo self-assigned this Jul 5, 2023
@l2hyunwoo l2hyunwoo requested a review from a team as a code owner July 5, 2023 09:20
jihyeonAnAn
jihyeonAnAn approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@jihyeonAnAn jihyeonAnAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 저렇게 깔끔하게 작성하도록 연습 많이 하겠습니다!
control + Alt + L을 습관화 해야겠군요 앞으로 viewBinding도 저렇게 하는 방식으로 하겠습니다! 꼼꼼하게 봐주셔서 감사합니다!

app/src/main/java/com/teampophory/pophory/feature/signup/SignUpFirstFragment.kt
_binding = FragmentSignUpFirstBinding.inflate(inflater, container, false)
return binding.root
): View {
return FragmentSignUpFirstBinding.inflate(inflater, container, false).root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binding.inflate(inflater, container, false).root 로 작성하는 것과 무슨 차이가 있는 건가요??!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihyeonAnAn 이거 알려줄게

@l2hyunwoo l2hyunwoo merged commit 584298c into develop Jul 5, 2023
1 check passed
@l2hyunwoo l2hyunwoo deleted the feature/refactor-code branch July 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihyeonAnAn jihyeonAnAn jihyeonAnAn approved these changes

Assignees

@l2hyunwoo l2hyunwoo

Labels
🐯 이현우 이현우가 했다 🔨 Refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l2hyunwoo @jihyeonAnAn