[feature/myPage] myPage 진행상황 공유 #57

librarywon · 2023-07-03T10:57:26Z

이슈 코드

close [feature/mypage]: mypage 기능 구현 및 UI 구현 #56

📸 스크린샷

🍀 관련 이슈

아이템이 3개 밖에 불러와지지 않는 문제가 있음 -> 해결

kez-lab · 2023-07-03T14:14:30Z

app/src/main/java/com/teampophory/pophory/data/repository/fake/FakeMyPageInfoRepository.kt

+        }
+    }
+
+    override suspend fun getPhotos(): Result<PhotoListResponse> {
+        TODO("Not yet implemented")
+    }
+}


MyPage관련 Repository Interface를 따로 작성하는 것이 좋아보입니다.

확인하였고 반영하였습니다 감사합니다!

kez-lab · 2023-07-03T14:15:28Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+    private var myPageAdapter: MyPageAdapter? = null
+


onDestroyView에서 null로 다시 리소스 해제를 해주시면 좋을 것 같습니다.

감사합니다 👍

kez-lab · 2023-07-03T14:16:53Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)
+        initObserver()
+        initRecyclerView()
+    }
+
+    private fun initObserver() {
+        viewModel.photoList.observe(viewLifecycleOwner) { myPageInfoState ->
+            when (myPageInfoState) {
+                is MyPageInfoState.Uninitialized -> {
+                    viewModel.getMyPageInfo()
+                }


Uninitialized 내에서 initRecyclerView를 선언하는 것이 좋아보입니다.
순서는
initRecyclerView()
viewModel.getMyPageInfo()

반영하였습니다!!

kez-lab · 2023-07-03T14:19:51Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+
+        myPageAdapter = MyPageAdapter(ItemDiffCallback(
+            onItemsTheSame = { old, new -> old == new },
+            onContentsTheSame = { old, new -> old == new }
+        )) { position ->
+            val photoList = viewModel.photoList.value
+            if (photoList is MyPageInfoState.SuccessPhotos) {


ItemDiffCallback 을 Adapter의 생성자로 외부에서 주입받는 것이 아닌 super의 생성자에서 생성해주어도 괜찮을 것 같습니다.
@l2hyunwoo 좋은 방법 맞을까요?

네 그게 좀더 가독성에 좋을 것 같습니당. @KwakEuiJin cc. @librarywon

kez-lab · 2023-07-03T14:22:49Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageViewModel.kt

+
+    init {
+        getMyPageInfo()
+    }
+}


@l2hyunwoo
Fragment단의 state 구독의 Uninitiialize 에서 getMyPageInfo를 부르는게 좋을까요? 아니면 init 블럭 내에 있는게 좋을까요? 일단 지금은 중복되어있어서 하나는 제거해야하는데 뭐가 좋은지 잘모르겠습니다

init { getMyPageInfo() }

를 제거하였습니다 !

오호 이유가 무엇인가요!?

오류를 수정하던 도중 현우형이 지우셔서 이유를 물어보겠습니다!

일단 레이아웃 에러 해결 도중에 지운거여서 별 이유는 딱히 없습니다.

kez-lab · 2023-07-03T14:25:04Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/model/MypageInfo.kt

+data class MyPageInfo(
+    val realName: String,
+    val photoCount: Int,
+    val photos: List<Photo>? = null
+) {
+    data class Photo(
+        val photoId: Long? = null,
+        val photoUrl: String? = null
+    )


mapping되는 부분에서 보니 nonull한 타입으로 반환됩니다. nullable한 타입은 변경해주시면 감사하겠습니다.

네 확인하였습니다!

l2hyunwoo · 2023-07-04T05:25:07Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+        val fullText = getString(R.string.mypage_picture_count, myPageInfoDataPhotoCount)
+        val coloredText = myPageInfoDataPhotoCount.toString()
+
+        val spannableStringBuilder = SpannableStringBuilder(fullText)
+        val start = fullText.indexOf(coloredText)
+        val end = start + coloredText.length
+
+        if (start != -1) {
+            spannableStringBuilder.setSpan(
+                ForegroundColorSpan(
+                    ContextCompat.getColor(
+                        requireContext(),
+                        R.color.pophory_purple
+                    )
+                ),
+                start,
+                end,
+                Spannable.SPAN_EXCLUSIVE_EXCLUSIVE
+            )
+        }
+
+        binding.tvMypagePictureCount.text = spannableStringBuilder


로직 정말 잘 구현했어 👍🏻

감사합니다 ㅎㅎ 😄 뿌듯

l2hyunwoo · 2023-07-04T05:25:28Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageViewModel.kt

+            //Empty List
+//            myPageInfoRepository.getMyPageEmtpyInfo()
+//                .onSuccess {
+//                    _myPageUserInfo.value = MyPageInfoState.SuccessPhotos(it.toMyPageInfo())
+//                }.onFailure {
+//                    _myPageUserInfo.value = MyPageInfoState.Error(it)
+//                }


주석 표기된건 필요 없으면 바로 삭제해줘. 나중에 이게 왜 주석친지 모르는 경우도 발생할 수 있어.

넵 지우도록 하겠습니다!

l2hyunwoo · 2023-07-04T05:26:00Z

app/src/main/res/layout/fragment_mypage.xml

+                android:layout_width="180dp"
+                android:layout_height="180dp"


고정 dp, 고정 비율이면 dimension_ratio 였나 그거 쓰면 될 것 같음

l2hyunwoo

추가 리뷰

l2hyunwoo · 2023-07-04T05:27:39Z

app/src/main/java/com/teampophory/pophory/data/repository/fake/FakePhotoRepository.kt

@@ -41,4 +42,5 @@ class FakePhotoRepository : PhotoRepository {
            )
        }
    }
+


l2hyunwoo · 2023-07-04T05:27:53Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+                            tvMypageFeedEmpty.visibility = View.VISIBLE
+                        }
+                    }
+


l2hyunwoo · 2023-07-04T05:28:10Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+                            ivMypageFeedEmpty.visibility = View.GONE
+                            tvMypageFeedEmpty.visibility = View.GONE


isVisible = false 뭐 이런식으로 가도 되지 않을까 싶은데...?

진행해보겠습니다!

이렇게 개선했습니다!

val isNotEmpty = myPageInfoState.data.photos.isNotEmpty() if(isNotEmpty) { myPageAdapter?.submitList(myPageInfoState.data.photos) } rvMypage.isVisible = isNotEmpty ivMypageFeedEmpty.isVisible = !isNotEmpty tvMypageFeedEmpty.isVisible = !isNotEmpty

l2hyunwoo · 2023-07-04T05:28:38Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+
+        myPageAdapter = MyPageAdapter(ItemDiffCallback(
+            onItemsTheSame = { old, new -> old == new },
+            onContentsTheSame = { old, new -> old == new }
+        )) { position ->
+            val photoList = viewModel.photoList.value
+            if (photoList is MyPageInfoState.SuccessPhotos) {


네 그게 좀더 가독성에 좋을 것 같습니당. @KwakEuiJin cc. @librarywon

l2hyunwoo · 2023-07-04T05:28:53Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+            if (photoList is MyPageInfoState.SuccessPhotos) {
+                val itemId = photoList.data.photos.getOrNull(position)?.photoId
+                toast(itemId.toString());
+                //TODO intent photo_detail activity


l2hyunwoo · 2023-07-04T05:29:57Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageInfoState.kt

+sealed class MyPageInfoState {
+    object Uninitialized : MyPageInfoState()
+    object Loading : MyPageInfoState()
+    data class SuccessPhotos(val data: MyPageInfo) : MyPageInfoState()
+    data class Error(val error: Throwable) : MyPageInfoState()


의진이거 보고 참고 한 것 같은데 성공했을때의 data class 네이밍이 저게 들어가는게 맞나 다시 한번 생각해봐. 그리고 이 구조를 사용하는게 좋은지도 생각을 해보고. 왜 내가 Ui State를 이렇게 사용하고 유지보수할 때 어떤 장점이 생기는지에 대해 생각을 해보면 좋을 것 같아

참고해서 진행하다보니 간과하고 지나간 면이 있었던 것 같습니다. Ui State에 대해서 더 고민해보겠습니다!

l2hyunwoo · 2023-07-04T05:30:24Z

...main/java/com/teampophory/pophory/feature/home/mypage/decorator/GridSpacingItemDecoration.kt

+class GridSpacingItemDecoration(private val spanCount: Int, private val spacing: Int, private val includeEdge: Boolean) : ItemDecoration() {
+
+    override fun getItemOffsets(outRect: Rect, view: View, parent: RecyclerView, state: State) {
+        val position = parent.getChildAdapterPosition(view) // item position
+        val column = position % spanCount // item column
+
+        if (includeEdge) {
+            outRect.left = spacing - column * spacing / spanCount // spacing - column * ((1f / spanCount) * spacing)
+            outRect.right = (column + 1) * spacing / spanCount // (column + 1) * ((1f / spanCount) * spacing)
+
+            if (position < spanCount) { // top edge
+                outRect.top = spacing
+            }
+            outRect.bottom = spacing // item bottom
+        } else {
+            outRect.left = column * spacing / spanCount // column * ((1f / spanCount) * spacing)
+            outRect.right = spacing - (column + 1) * spacing / spanCount // spacing - (column + 1) * ((1f / spanCount) * spacing)
+            if (position >= spanCount) {
+                outRect.top = spacing // item top
+            }
+        }
+    }
+}


core common 모듈로 빼자

넵 core/common/view/ViewExt에 추가하겠습니다!

kez-lab

LGTM 🥇

l2hyunwoo

한번만...더 수정해줘!

l2hyunwoo · 2023-07-04T12:50:00Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

-
-                        val isNotEmpty = myPageInfoState.data.photos.isNotEmpty()
+                    val isNotEmpty = myPageInfoState.data.photos.isNotEmpty()
+                    val myPageInfoData = arrayListOf<Any>().apply {


구두로 리뷰함

l2hyunwoo · 2023-07-04T12:50:40Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+
+

제거하였습니다!

l2hyunwoo · 2023-07-04T12:51:10Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/adapter/MyPageAdapter.kt

+) : ListAdapter<Any, RecyclerView.ViewHolder>(
+    ItemDiffCallback<Any>(


이것도 MyPageInfoState로!

변경하였습니다!

librarywon added 🦈서재원 서재원이 했다 ✨ Feature 기능 개발 labels Jul 3, 2023

librarywon requested a review from a team as a code owner July 3, 2023 10:57

librarywon self-assigned this Jul 3, 2023

kez-lab requested changes Jul 3, 2023

View reviewed changes

l2hyunwoo reviewed Jul 4, 2023

View reviewed changes

l2hyunwoo requested changes Jul 4, 2023

View reviewed changes

kez-lab approved these changes Jul 4, 2023

View reviewed changes

l2hyunwoo approved these changes Jul 4, 2023

View reviewed changes

librarywon added 16 commits July 5, 2023 01:13

[feat/store]: del legacy code

45ea78a

[feat/store]: feat MyFage

94fb0f2

[feat/store]: add fake Repository

f379320

[feat/store]: refactor approve code review

69feaf7

[feat/store]: add background store text

6007835

[feat/store]: UI albumPhotoCount

e6f3fa4

[feat/mypage]: UI photoCount

f33e23e

[feat/mypage]: add getMyPageEmtpyInfo

d707add

[feat/mypage]: UI EmtpyImage

9d607a6

[feat/mypage]: move GridSpacingItemDecoration to core/common

8019a79

[feat/mypage]: approve code review

e2d5e80

[feat/mypage]: add DiffUtil at MyPageAdapter super

0be8fbc

[feat/mypage]: add listener at iv_setting

eaf50b3

[feat/mypage]: refactor to MultiViewType Rv

97ea93c

[feat/mypage]: refactor Any Class

dabce59

[feat/store]: UI title logo margin edit

f916058

librarywon force-pushed the feature/mypage branch from 5ad0c76 to f916058 Compare July 4, 2023 16:14

librarywon added 3 commits July 5, 2023 01:41

[feat/mypage]: chore black del

cdd769a

[feat/mypage]: fix responsenamig

adfd16b

[feat/mypage]: fix bug

bfdf733

librarywon merged commit 8d3f365 into develop Jul 4, 2023
1 check passed

librarywon deleted the feature/mypage branch July 4, 2023 17:17

@@ @@ -41,4 +42,5 @@ class FakePhotoRepository : PhotoRepository { @@
                           )
                       }
                   }

		ivMypageFeedEmpty.visibility = View.GONE
		tvMypageFeedEmpty.visibility = View.GONE

		) : ListAdapter<Any, RecyclerView.ViewHolder>(
		ItemDiffCallback<Any>(

[feature/myPage] myPage 진행상황 공유 #57

[feature/myPage] myPage 진행상황 공유 #57

Conversation

librarywon commented Jul 3, 2023 • edited Loading

이슈 코드

📸 스크린샷

🍀 관련 이슈

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l2hyunwoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kez-lab left a comment

Choose a reason for hiding this comment

l2hyunwoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

librarywon commented Jul 3, 2023 •

edited

Loading