Feature/force update #545

librarywon · 2024-07-25T06:08:30Z

이슈 코드

close [FEAT] 강제 업데이트 기능 구현 #536

📸 스크린샷

Screen_recording_20240731_175855.mp4

Screen_recording_20240731_180309.mp4

🍀 관련 이슈

강제 업데이트 로직을 개발하였습니다.
ForeceUpdateDialogFragment를 개발하였습니다.
서버에서 최소 version을 받아와서 체크하는 로직으로 변경하였습니다.
스플래시 에니메이션 시간을 1.5초로 변경하였습니다.

l2hyunwoo

로직상 이해 안되는 점 + 내가 생각하는 개선점 적어봤습니다. 확인 ㄱㄱ

l2hyunwoo · 2024-07-25T14:59:59Z

.../designsystem/src/main/java/com/teampophory/pophory/designsystem/dialog/ForceUpdateDialog.kt

+import com.teampophory.pophory.designsystem.R
+import com.teampophory.pophory.designsystem.databinding.DialogCommonOneButtonBinding
+
+class ForceUpdateDialog : DialogFragment() {


Suggested change

class ForceUpdateDialog : DialogFragment() {

class ForceUpdateDialogFragment : DialogFragment() {

l2hyunwoo · 2024-07-25T15:00:49Z

.../designsystem/src/main/java/com/teampophory/pophory/designsystem/dialog/ForceUpdateDialog.kt

+        val title = arguments?.getString("title", "")
+        val description = arguments?.getString("description", "")
+        val imageResId = arguments?.getInt("imageResId")
+        val buttonText = arguments?.getString("buttonText", "")


이거 stringArgs 같은 확장함수 있지 않았나?

l2hyunwoo · 2024-07-25T15:02:06Z

.../designsystem/src/main/java/com/teampophory/pophory/designsystem/dialog/ForceUpdateDialog.kt

+        ): ForceUpdateDialog {
+            ForceUpdateDialog().apply {
+                arguments = Bundle().apply {
+                    putString("title", title)
+                    putString("description", description)
+                    putInt("imageResId", imageResId)
+                    putString("buttonText", buttonText)
+                }
+            }.also {
+                return it
+            }


그냥

return ForceUpdateDialog().apply { arguments = Bundle().apply { putString("title", title) putString("description", description) putInt("imageResId", imageResId) putString("buttonText", buttonText) } }

이게 가독성 더 좋지 않나요..?

l2hyunwoo · 2024-07-25T15:02:16Z

.../designsystem/src/main/java/com/teampophory/pophory/designsystem/dialog/ForceUpdateDialog.kt

+        ): ForceUpdateDialog {
+            ForceUpdateDialog().apply {
+                arguments = Bundle().apply {
+                    putString("title", title)
+                    putString("description", description)
+                    putInt("imageResId", imageResId)
+                    putString("buttonText", buttonText)
+                }
+            }.also {
+                return it
+            }


그냥

return ForceUpdateDialog().apply { arguments = Bundle().apply { putString("title", title) putString("description", description) putInt("imageResId", imageResId) putString("buttonText", buttonText) } }

이게 가독성 더 좋지 않나요..?

재사용하지 않고 ForceUpdateDialog에 상수값을 넣어두는 것으로 변경하였습니다!

l2hyunwoo · 2024-07-25T15:06:08Z

data/config/src/main/java/com/teampophory/pophory/config/remote/RemoteConfigManager.kt

+        remoteConfig.setDefaultsAsync(
+            mapOf(
+                "minimum_required_version" to "1.4.0"
+            )
+        )


이거 default를 set하면 최소 버전 업할때마다 여기 코드를 손수 바꿔주고 배포를 해줘야 하겠네요? 강업은 서버에서 언제든지 변수를 조절해서 바꾸는데 의미가 있는건데 이런 default 설정은 불필요한 것 같아요.

물론 파베에서 minimum_required_version 값을 설정해줘서 이 디폴트는 그냥 순수 디폴트다 라고 말은 할 수 있겠지만, 로컬 디폴트도 결국에는 우리가 원하는 수준까지는 올려줘야 하는걸 신경써야 하는거니까 유지보수 코스트는 올라가는거라고 볼 수 있죠

로직을 생각해서 반영했는데 체크해주시면 감사드리겠습니다.

l2hyunwoo · 2024-07-25T15:07:06Z

data/config/src/main/java/com/teampophory/pophory/config/remote/RemoteConfigManager.kt

+    fun getString(key: String): String {
+        return remoteConfig.getString(key)
+    }


나라면 operator fun get 함수 오버로딩 할 것 같음. 의미론상 그게 좀 더 적절할 것 같고, getString은 너무 포괄적인 함수이름이야... getStringKey일 수 있고, getStringValue일 수 있자늠?

넵 이거 제거 해버렸습니다!

l2hyunwoo · 2024-07-25T15:08:20Z

...fig/src/main/java/com/teampophory/pophory/config/remote/datasource/RemoteConfigDataSource.kt

+        suspendCancellableCoroutine { continuation ->
+            remoteConfig.fetchAndActivate().addOnCompleteListener { task ->
+                if (task.isSuccessful) {
+                    continuation.resume(remoteConfig[key])
+                } else {
+                    continuation.resume(null)
+                }
+            }
+        }


kotlinx-coroutines-play-services
이거 참고해보실라우?

제거완료

l2hyunwoo · 2024-07-25T15:08:43Z

.../main/java/com/teampophory/pophory/config/remote/repository/DefaultRemoteConfigRepository.kt

+) : RemoteConfigRepository {
+
+    override suspend fun getMinRequiredVersion(): String {
+        val minVersion = remoteConfigDataSource.getString(KEY_MIN_VERSION, "1.4.0")


디폴트 여긴 1.4.0인데 내부에선 왜 1.4.1 쓰고 있죠?

l2hyunwoo · 2024-07-25T15:09:16Z

...config/src/main/java/com/teampophory/pophory/config/remote/usecase/CheckAppVersionUseCase.kt

+    private fun isUpdateRequired(currentVersion: String, minRequiredVersion: String): Boolean {
+        val currentVersionParts = currentVersion.split(".").map { it.toIntOrNull() ?: 0 }
+        val minVersionParts = minRequiredVersion.split(".").map { it.toIntOrNull() ?: 0 }
+
+        for (i in currentVersionParts.indices) {
+            val currentPart = currentVersionParts.getOrElse(i) { 0 }
+            val minPart = minVersionParts.getOrElse(i) { 0 }
+            if (currentPart < minPart) {
+                return true
+            } else if (currentPart > minPart) {
+                return false
+            }
+        }
+        return false
+    }


이거 사용해보세요

제거 완료

l2hyunwoo

생각해보니까 firebase 안쓰네? 라이브러리 없애주세요!

l2hyunwoo · 2024-07-31T14:13:54Z

gradle/libs.versions.toml

@@ -198,6 +200,7 @@ sentry = { module = "io.sentry:sentry", version.ref = "sentry-android" }

 zxing-core = { module = "com.google.zxing:core", version = "zxing-core" }
 zxing-android-embedded = { module = "com.journeyapps:zxing-android-embedded", version.ref = "zxing-android-embedded" }
+firebase-config-ktx = { group = "com.google.firebase", name = "firebase-config-ktx", version.ref = "firebaseConfigKtx" }


Suggested change

firebase-config-ktx = { group = "com.google.firebase", name = "firebase-config-ktx", version.ref = "firebaseConfigKtx" }

firebase-config-ktx = { group = "com.google.firebase", name = "firebase-config", version.ref = "firebaseConfigKtx" }

이거 ktx는 예전 라이브러리일거입니다. 지금은 firebase-config로 다 대체되었어.

참고 - https://firebase.google.com/support/release-notes/android

아 그리고 이거 라이브러리 없애야할듯? 사용하는 곳 없는거 보니

맞습니다 제거할게요!

l2hyunwoo · 2024-07-31T14:14:05Z

gradle/libs.versions.toml

+appVersion = "1.4.1"
+versionCode = "10401"


여기서 1.4.1 버전을 올리나요?

이건 정하기 나름인 것 같습니다!

여기서 올리는 것보단 릴리즈 브랜치에서 1.4.1로 올리는게 나을 것 같습니다. 원복해주시는게 좋을 것 같아요!

l2hyunwoo · 2024-07-31T14:15:14Z

feature/onboarding/src/main/java/com/teampophory/pophory/onboarding/OnBoardingViewModel.kt

+    private fun getCurrentVersionName(): String {
+        return try {
+            val packageInfo = context.packageManager.getPackageInfo(context.packageName, 0)
+            packageInfo.versionName
+        } catch (e: Exception) {
+            "1.4.1"
+        }
+    }


l2hyunwoo · 2024-07-31T14:20:23Z

domain/config/proguard-rules.pro

삭제 해도 될듯

l2hyunwoo · 2024-07-31T14:21:03Z

data/config/src/main/java/com/teampophory/pophory/config/remote/di/RemoteConfigModule.kt

+    fun provideMinimumVersionService(@Secured retrofit: Retrofit): MinimumVersionService =
+        retrofit.create(MinimumVersionService::class.java)


Suggested change

fun provideMinimumVersionService(@Secured retrofit: Retrofit): MinimumVersionService =

retrofit.create(MinimumVersionService::class.java)

fun provideMinimumVersionService(@Secured retrofit: Retrofit): MinimumVersionService = retrofit.create()

이렇게 해도 됩니당

l2hyunwoo · 2024-07-31T14:21:15Z

data/config/proguard-rules.pro

지워도 될듯?

l2hyunwoo

고생하셨습니다.

l2hyunwoo · 2024-07-31T14:58:51Z

gradle/libs.versions.toml

@@ -79,6 +79,7 @@ kakao = "2.20.4"
 splash-screen = "1.0.1"
 javax-inject = "1"
 spotless = "6.25.0"
+firebaseConfigKtx = "22.0.0"


이거만 삭제합시다.

librarywon added the ✨ Feature 기능 개발 label Jul 25, 2024

librarywon self-assigned this Jul 25, 2024

librarywon requested a review from a team as a code owner July 25, 2024 06:08

l2hyunwoo requested changes Jul 25, 2024

View reviewed changes

librarywon requested a review from l2hyunwoo July 31, 2024 09:17

l2hyunwoo requested changes Jul 31, 2024

View reviewed changes

l2hyunwoo force-pushed the develop branch from 88b05fa to 4c2b27a Compare July 31, 2024 14:56

librarywon added 22 commits July 31, 2024 23:57

[feature/force_update] app version, add firebase Remote config

425ecf1

[feature/force_update] create data/config module

dab5ebf

[feature/force_update] create domain/config module

bab87fb

[feature/force_update] add dependency

c5ce163

[feature/force_update] add ForceUpdateDialog

fab69ac

[feature/force_update] add version check logic

f9b1eef

[feature/force_update] modify minimumFetchIntervalInSeconds

70ae36f

[feature/force_update] build remove timber

13f2e07

[feature/force_update] 스플래시 AnimationDuration 조정

7631c75

[feature/force_update] firebase remoteConfig 제거

e2cf5a9

[feature/force_update] ic_customizing_done 추가

20c5694

[feature/force_update] domain useCase 로직 변경

a3ed458

[feature/force_update] 서버에서 minium version 받아오는 로직으로 변경

83d2cd1

[feature/force_update] ForceUpdateDialog 인자 제거 정적 상수 사용

fa498ff

[feature/force_update] 변경된 version check 로직 적용

5b9edc9

[feature/force_update] ForceUpdateDialogFragment로 네이밍 변경

fae6237

[feature/force_update] Minimum version default 값 제거

2464fa2

[feature/force_update] firebase-config 제거

7aa9495

[feature/force_update] firebase-config 의존성 제거

ba8f9fa

[feature/force_update] proguard 제거

8eb95c2

[feature/force_update] retrofit2.create를 이용한 로직으로 변경

dca08a1

[feature/force_update] config 모듈 firebase 로직 전부 제거

064534c

l2hyunwoo force-pushed the feature/force_update branch from 2f86aee to 064534c Compare July 31, 2024 14:58

l2hyunwoo approved these changes Jul 31, 2024

View reviewed changes

[feature/force_update] Remove useless library version

ad24b9d

librarywon merged commit 74b238f into develop Jul 31, 2024
1 check passed

librarywon deleted the feature/force_update branch July 31, 2024 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/force update #545

Feature/force update #545

librarywon commented Jul 25, 2024 •

edited

Loading

l2hyunwoo left a comment

l2hyunwoo Jul 25, 2024

l2hyunwoo Jul 25, 2024

l2hyunwoo Jul 25, 2024

l2hyunwoo Jul 25, 2024

librarywon Jul 31, 2024

l2hyunwoo Jul 25, 2024

librarywon Jul 31, 2024

l2hyunwoo Jul 25, 2024

librarywon Jul 31, 2024

l2hyunwoo Jul 25, 2024

librarywon Jul 31, 2024

l2hyunwoo Jul 25, 2024

l2hyunwoo Jul 25, 2024

librarywon Jul 31, 2024

l2hyunwoo left a comment

l2hyunwoo Jul 31, 2024

l2hyunwoo Jul 31, 2024

librarywon Jul 31, 2024

l2hyunwoo Jul 31, 2024

librarywon Jul 31, 2024

l2hyunwoo Jul 31, 2024

librarywon Jul 31, 2024

l2hyunwoo Jul 31, 2024

l2hyunwoo Jul 31, 2024

l2hyunwoo Jul 31, 2024

l2hyunwoo Jul 31, 2024

l2hyunwoo left a comment

l2hyunwoo Jul 31, 2024

	class ForceUpdateDialog : DialogFragment() {
	class ForceUpdateDialogFragment : DialogFragment() {

	firebase-config-ktx = { group = "com.google.firebase", name = "firebase-config-ktx", version.ref = "firebaseConfigKtx" }
	firebase-config-ktx = { group = "com.google.firebase", name = "firebase-config", version.ref = "firebaseConfigKtx" }

		fun provideMinimumVersionService(@Secured retrofit: Retrofit): MinimumVersionService =
		retrofit.create(MinimumVersionService::class.java)

		appVersion = "1.4.1"
		versionCode = "10401"

Feature/force update #545

Feature/force update #545

Conversation

librarywon commented Jul 25, 2024 • edited Loading

이슈 코드

📸 스크린샷

🍀 관련 이슈

l2hyunwoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l2hyunwoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l2hyunwoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

librarywon commented Jul 25, 2024 •

edited

Loading