-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate watch history to Jetpack Compose #11947
base: refactor
Are you sure you want to change the base?
Migrate watch history to Jetpack Compose #11947
Conversation
# Conflicts: # app/src/main/java/org/schabi/newpipe/local/history/StatisticsPlaylistFragment.java
# Conflicts: # app/src/main/java/org/schabi/newpipe/ui/components/items/stream/StreamMenu.kt
There should be a confirmation screen after "clear history" button clicked I guess |
135d560
to
e5882af
Compare
e5882af
to
dbe3011
Compare
Is it possible to put get the background, pop up, and play all actions in a single row? The buttons and sort by drop down use a lot of vertical space. |
A scrollable row could be used to keep the buttons in the same row (at the moment, a FlowRow is used to adjust the buttons if the screen width is too narrow). The sort box could also be included in the same row if needed. |
@TobiGr I revised the UI again to use a segmented button instead of a dropdown. |
thanks. I am wondering whether the checkmark is the right icon to use here. Did you try to use the sort icon? |
fbbc60b
to
2bafa2c
Compare
I would put the Clear button in the three-dot menu, it's rarely used and especially should not be pressed on by accident. |
It opens a confirmation dialog first. |
I know, but I still think it would be better in the 3-dot menu (also because it would use up less space). Consider that if somebody doesn't want history they would just disable it, they wouldn't keep using the clear button. |
Good point. I made the change. |
|
Would you please restore earlier default behavior of "sort by" to "date", it defaults to "views" in this PR. Also noticed a minor bug: last selected option isn't saved, it switches to sort by "views" even after manually changing it to sort by "date" after reopening the app. |
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Screen_recording_20250311_110112.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence