Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate playlist fragment to Jetpack Compose #11259

Draft
wants to merge 72 commits into
base: refactor
Choose a base branch
from

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jul 10, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Rewrite the playlist fragment using Jetpack Compose. As part of this change, composable functions for the stream views (list, grid, card) were added as well for use in future refactoring.
  • Display a dropdown menu instead of a dialog when long-clicking a stream.
  • Handle the playlist stream loading functionality using the Paging library and a view model.
  • TODO: Add playlist buttons, handle dropdown on-click events.

Before/After Screenshots/Screen Record

Screen_recording_20240710_085704.mp4

Fixes the following issue(s)

  • Fixes #

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Jul 10, 2024
@Isira-Seneviratne Isira-Seneviratne changed the base branch from dev to refactor July 10, 2024 03:37
@Isira-Seneviratne Isira-Seneviratne force-pushed the Playlist-Compose branch 4 times, most recently from 64bdabb to b6751c2 Compare July 16, 2024 13:58
@Isira-Seneviratne Isira-Seneviratne force-pushed the Playlist-Compose branch 5 times, most recently from d9a06a8 to 8049fa5 Compare July 22, 2024 10:36
Copy link

sonarcloud bot commented Aug 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@TobiGr TobiGr added the GUI Issue is related to the graphical user interface label Sep 2, 2024
@ShareASmile ShareASmile added the rewrite Issues and PRs related to rewrite label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issue is related to the graphical user interface rewrite Issues and PRs related to rewrite size/giant PRs with more than 750 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants