Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate comment fragments to Jetpack Compose #11060

Open
wants to merge 51 commits into
base: refactor
Choose a base branch
from
Open

Migrate comment fragments to Jetpack Compose #11060

wants to merge 51 commits into from

Commits on Aug 11, 2024

  1. Convert comment replies views to Jetpack Compose

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    bda961a View commit details
    Browse the repository at this point in the history

  2. Rename .java to .kt

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    644a345 View commit details
    Browse the repository at this point in the history

  3. Use reply header composable in fragment

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e05d977 View commit details
    Browse the repository at this point in the history

  4. Added like count

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    8ce9a7e View commit details
    Browse the repository at this point in the history

  5. Added missing comment features, fixed theming

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    56c80ce View commit details
    Browse the repository at this point in the history

  6. Add comment ellipsis

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    1620668 View commit details
    Browse the repository at this point in the history

  7. Update replies fragment to use the comment composable as well

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    341cc37 View commit details
    Browse the repository at this point in the history

  8. Improve previews, display date of comment

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    11bb249 View commit details
    Browse the repository at this point in the history

  9. Fixed some comment issues

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e30d5e4 View commit details
    Browse the repository at this point in the history

  10. Use AnnotatedString to handle HTML parsing

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    1908e18 View commit details
    Browse the repository at this point in the history

  11. Add replies button

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e92ba8f View commit details
    Browse the repository at this point in the history

  12. Set view strategy

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    5841eaa View commit details
    Browse the repository at this point in the history

  13. Fixed like count display

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    0ec81c9 View commit details
    Browse the repository at this point in the history

  14. Fixed fragment title

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    5bfb044 View commit details
    Browse the repository at this point in the history

  15. Rename .java to .kt

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    be037e0 View commit details
    Browse the repository at this point in the history

  16. Migrate comments fragment to Jetpack Compose

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    9c52e03 View commit details
    Browse the repository at this point in the history

  17. Added scrollbar to comment section

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    9331095 View commit details
    Browse the repository at this point in the history

  18. Replace CommentRepliesFragment with bottom sheet composable, improve … 

    …previews
    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    b9dd707 View commit details
    Browse the repository at this point in the history

  19. Replace Spacers with the horizontalArrangement parameter

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    b092fe2 View commit details
    Browse the repository at this point in the history

  20. Handle no comments and comments disabled scenarios

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    5e7e14e View commit details
    Browse the repository at this point in the history

  21. Rm redundant Surface

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    909d214 View commit details
    Browse the repository at this point in the history

  22. Improve code organization

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    369a46f View commit details
    Browse the repository at this point in the history

  23. Cache paging data using the cachedIn() extension

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    02c5f26 View commit details
    Browse the repository at this point in the history

  24. Add comment view model

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    c5d94a5 View commit details
    Browse the repository at this point in the history

  25. Rm extra padding in header

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e72da94 View commit details
    Browse the repository at this point in the history

  26. Replace padding modifier with verticalArrangement in comment header

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    42cb914 View commit details
    Browse the repository at this point in the history

  27. Added loading indicator

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    1009dc4 View commit details
    Browse the repository at this point in the history

  28. Rm unused method

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    d131d33 View commit details
    Browse the repository at this point in the history

  29. Improve comment loading smoothness

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    ac1ca14 View commit details
    Browse the repository at this point in the history

  30. Animate comment expand/collapse

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e639b02 View commit details
    Browse the repository at this point in the history

  31. Make parsed links clickable, visible

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    4740e3b View commit details
    Browse the repository at this point in the history

  32. Fix alignment of comment message

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    edab9a6 View commit details
    Browse the repository at this point in the history

  33. Fix some modifiers

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    f984b26 View commit details
    Browse the repository at this point in the history

  34. Added DescriptionText composable

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    ea414f5 View commit details
    Browse the repository at this point in the history

  35. Improved component organisation

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    eaac7f3 View commit details
    Browse the repository at this point in the history

  36. Update Kotlin to 2.0, update dependencies and fix issues

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e955bee View commit details
    Browse the repository at this point in the history

  37. Always show comment thumbnails, even if placeholders

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    f9dae90 View commit details
    Browse the repository at this point in the history

  38. Use nested scroll modifier

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e082bca View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Rm unused declaration

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    294b9cf View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'refs/heads/refactor' into Comments-Compose 

    # Conflicts:
#	app/build.gradle
    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3641698 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Use Fragment.content extension, improve comment composables

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d3a6991 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Improve compose function organisation

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f9340ae View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Fix text color in bottom sheet

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5fffee2 View commit details
    Browse the repository at this point in the history

  2. Address code review comments

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b1add13 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Implement copy on long click

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    941b8eb View commit details
    Browse the repository at this point in the history

  2. Reduce preview count

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    4cac111 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Display number of comments

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3785404 View commit details
    Browse the repository at this point in the history

  2. Make lazy column scrollbars red

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    62d4044 View commit details
    Browse the repository at this point in the history

  3. Improve loading indicator positioning

    @Isira-Seneviratne
    Isira-Seneviratne committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    823d4a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Update dependencies

    @Isira-Seneviratne
    Isira-Seneviratne committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5017f4f View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Avoid issues if context is a ContextWrapper

    @Isira-Seneviratne
    Isira-Seneviratne committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3177ca6 View commit details
    Browse the repository at this point in the history