Network [#55] BaseURL 설정 및 네트워크 세팅 #56
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // | ||
| // BaseResponse.swift | ||
| // DontBe-iOS | ||
| // | ||
| // Created by 변희주 on 1/14/24. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| struct BaseResponse<T: Decodable>: Decodable { | ||
| let status: Int | ||
| let success: Bool | ||
| let message: String | ||
| let data: T? | ||
| } | ||
|
There was a problem hiding this comment. 해당 코드 패치는 큰 결함이 없어 보입니다. 다만, 한 가지 개선점을 제안드릴게요. 굳이 struct BaseResponse<T>: Decodable where T: Decodable {
let status: Int
let success: Bool
let message: String
let data: T?
}이와 같이 수정하면 현재의 코드와 동일한 동작을 하지만, |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // | ||
| // SocialLoginRequestDTO.swift | ||
| // DontBe-iOS | ||
| // | ||
| // Created by 변희주 on 1/14/24. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| struct SocialLoginRequestDTO: Encodable { | ||
| let socialPlatform: String | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // | ||
| // SocialLoginResponseDTO.swift | ||
| // DontBe-iOS | ||
| // | ||
| // Created by 변희주 on 1/14/24. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| // MARK: - SocilLoginResponseDTO | ||
| struct SocialLoginResponseDTO: Decodable { | ||
| let nickName: String | ||
| let memberId: Int | ||
| let accessToken, refreshToken: String | ||
| let memberProfileUrl: String | ||
| let isNewUser: Bool | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| // | ||
| // KakaoLoginService.swift | ||
| // DontBe-iOS | ||
| // | ||
| // Created by 변희주 on 1/14/24. | ||
| // | ||
|
|
||
| import Foundation | ||
| import Foundation | ||
|
|
||
| protocol SocialLoginServiceType { | ||
| func makeRequestURL(accessToken: String) -> URLRequest | ||
| func postData(accessToken: String) async throws -> BaseResponse<SocialLoginResponseDTO>? | ||
| func parseData(data: Data) -> BaseResponse<SocialLoginResponseDTO>? | ||
| } | ||
|
|
||
| final class SocialLoginService: SocialLoginServiceType { | ||
|
|
||
| func makeRequestURL(accessToken: String) -> URLRequest { | ||
|
|
||
| let baseURL = Config.baseURL | ||
|
|
||
| let urlString = "\(baseURL)/auth" | ||
|
|
||
| // URL 생성 | ||
| guard let url = URL(string: urlString) else { | ||
| fatalError("Failed to create URL") | ||
| } | ||
|
|
||
| // URLRequest 생성 | ||
| var request = URLRequest(url: url) | ||
| request.httpMethod = "POST" | ||
|
|
||
| // 헤더 추가 | ||
| let header = ["Content-Type": "application/json", | ||
| "Authorization": "Bearer \(accessToken)"] | ||
| header.forEach { | ||
| request.addValue($0.value, forHTTPHeaderField: $0.key) | ||
| } | ||
|
|
||
| // 리퀘스트 바디 설정 | ||
| let requestBody = SocialLoginRequestDTO(socialPlatform: "KAKAO") | ||
| do { | ||
| let jsonData = try JSONEncoder().encode(requestBody) | ||
| request.httpBody = jsonData | ||
| } catch { | ||
| print("Failed to encode request body: \(error)") | ||
| } | ||
|
|
||
| return request | ||
| } | ||
|
|
||
| func postData(accessToken: String) async throws -> BaseResponse<SocialLoginResponseDTO>? { | ||
| do { | ||
| let request = self.makeRequestURL(accessToken: accessToken) | ||
| let (data, response) = try await URLSession.shared.data(for: request) | ||
|
|
||
| guard let httpResponse = response as? HTTPURLResponse else { | ||
| throw NetworkError.responseError | ||
| } | ||
|
|
||
| switch httpResponse.statusCode { | ||
| case 200..<300: | ||
| return parseData(data: data) | ||
| case 400: | ||
| throw NetworkError.badRequestError | ||
| case 401: | ||
| throw NetworkError.unautohorizedError | ||
| case 404: | ||
| throw NetworkError.notFoundError | ||
| case 500: | ||
| throw NetworkError.internalServerError | ||
| default: | ||
| throw NetworkError.unknownError | ||
| } | ||
| } catch { | ||
| throw error | ||
| } | ||
| } | ||
|
|
||
| func parseData(data: Data) -> BaseResponse<SocialLoginResponseDTO>? { | ||
| do { | ||
| let jsonDecoder = JSONDecoder() | ||
| let result = try jsonDecoder.decode(BaseResponse<SocialLoginResponseDTO>.self, from: data) | ||
| return result | ||
| } catch { | ||
| print(error) | ||
| return nil | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 코드 패치에는 다음과 같은 변경 사항이 있습니다:
파일 추가:
SocialLoginService.swift,BaseResponse.swift,SocialLoginResponseDTO.swift,SocialLoginRequestDTO.swift파일이 소스에 추가되었습니다.그룹 추가:
SocialLogin그룹이Network그룹 안에 추가되었습니다.DTO와Service그룹이SocialLogin그룹 안에 추가되었습니다.수정 사항 및 개선 제안은 제공하지 않았습니다.