-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] #38 - 로딩 스피너 구현 #40
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아래는 코드 패치에 대한 간단한 코드 리뷰입니다. 버그 위험과/또는 개선 제안 사항을 환영합니다:
refreshControl
변수는 "UIRefreshControl"의 인스턴스를 나타내며, 새로고침 기능을 제공합니다.setRefreshControll()
메서드가 추가되어 해당 뷰 컨트롤러에서 리프레시 컨트롤을 설정하고 있습니다.refreshPost()
메서드는refreshControl
의 valueChanged 이벤트와 연결됩니다. 서버 통신 영역에 관련 코드가 필요할 것입니다.finishedRefreshing()
메서드는 리프레시가 완료되었을 때 호출되며,refreshControl.endRefreshing()
을 호출하여 리프레시를 종료합니다.개선 제안:
refreshPost()
메서드에서 비동기 서버 통신 부분이 필요합니다. 현재 주석 처리되어 있으므로 해당 영역에 적절한 서버 통신 로직을 추가해야 합니다.finishedRefreshing()
메서드에서perform(:with:afterDelay:)
메서드 대신 디스패치 큐를 사용하여 UI 업데이트를 지연시키는 방식을 고려해 볼 수 있습니다. 예를 들어,DispatchQueue.main.asyncAfter(deadline: .now() + 0.1)
를 사용하여 지정된 지연 시간 이후에refreshControl.endRefreshing()
을 호출할 수 있습니다.위의 제안사항 및 코드 리뷰는 해당 코드 조각의 한 부분에 대한 내용입니다. 컨트롤러의 다른 부분에서 발생할 수 있는 다른 문제나 개선점은 살펴볼 수 없으므로 전반적인 코드 품질과 일관성을 위해 전체 코드를 고려하는 것이 중요합니다.