Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : 식단 API 오류 수정 #237

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Fix : 식단 API 오류 수정 #237

merged 1 commit into from
Apr 21, 2024

Conversation

huiwoo-jo
Copy link
Contributor

@huiwoo-jo huiwoo-jo commented Apr 21, 2024 •
edited
Loading

📮 관련 이슈

✍️ 구현 내용

  • 빈 식단을 받았을 경우 api 통신을 받는 부분을 수정하였습니다.
  • takeIf로 로직을 받아 오류가 생긴 것으로 if-else로 수정하였습니다.

📷 구현 영상

주말일 경우 날짜를 선택한 경우
image image

✔️ 확인 사항

  • 컨벤션에 맞는 PR 타이틀
  • 관련 이슈 연결
  • PR 관련 정보 연결 (작업자, 라벨, 마일스톤 등)
  • Github Action 통과

@huiwoo-jo huiwoo-jo requested review from hoyahozz and m6z1 April 21, 2024 13:13
@huiwoo-jo huiwoo-jo self-assigned this Apr 21, 2024
m6z1
m6z1 approved these changes Apr 21, 2024
View reviewed changes
Copy link
Collaborator

@m6z1 m6z1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@huiwoo-jo huiwoo-jo merged commit f59c933 into develop Apr 21, 2024
1 check passed
@huiwoo-jo huiwoo-jo deleted the fix/cafeteria-api branch April 21, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m6z1 m6z1 m6z1 approved these changes

@hoyahozz hoyahozz Awaiting requested review from hoyahozz

Assignees

@huiwoo-jo huiwoo-jo

Labels
🔥HOTFIX 🩵희우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

식단 api 오류
2 participants
@huiwoo-jo @m6z1