Feat : 알림 권한 설정 다이어로그 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwoo-jo
added
🎨 DESIGN
huiwoo-jo
force-pushed
the
feature/onboarding-dialog
branch
from
63b9de5
to
a9c09a4
Compare
huiwoo-jo
force-pushed
the
feature/onboarding-dialog
branch
from
c6a8d37
to
00882d8
Compare
m6z1
reviewed
Apr 3, 2024
Comment on lines
12
to
+13
|
|
||
|
|
There was a problem hiding this comment.
두 줄 공백은 나중에 코드 리팩할 때 하나 씩 확인하면서 지워가면 좋을 것 같네용
| @@ -111,6 +117,24 @@ class SettingFragment : BaseFragment<FragmentSettingBinding, SettingViewModel>() | |||
| } | |||
| } | |||
|
|
|||
| fun checkPermission(){ | |||
Comment on lines
+26
to
+36
| // 제목, 내용 설정 | ||
| binding.customTvTitle.text = title | ||
| binding.customTvContent.text = content | ||
|
|
||
| // 취소 버튼 | ||
| binding.customTvBtn1.setOnClickListener { | ||
| dismiss() | ||
| } | ||
| // 확인 버튼 | ||
| binding.customTvBtn2.setOnClickListener { | ||
| val intent = |
There was a problem hiding this comment.
나중에 로직 분리하면 좋을 것 같아요!
그리고 onViewCreated 와 onCreatedView에서도 알아보심 좋을 듯 합니다 << 프레그먼트 생명주기
| android:background="@drawable/bg_stroke_gray300_radius_2dp"> | ||
|
|
||
| <TextView | ||
| android:id="@+id/customTvTitle" |
| android:layout_width="wrap_content" | ||
| android:layout_height="0dp" | ||
| android:layout_marginTop="24dp" | ||
| android:text="제목" |
There was a problem hiding this comment.
xml에서 위치를 확인하고 싶은 것이라면
hint:text="제목"
을 사용하시면 되구 사용하지 않는 text값은 지워줍시다용
| android:layout_marginTop="20dp" | ||
| android:layout_marginEnd="28dp" | ||
| android:layout_marginBottom="20dp" | ||
| android:text="취소" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
✍️ 구현 내용
취소: 다이어로그 창이 종료됩니다.설정 화면 이동:DMforU의 어플 권한 설정 창으로 이동합니다.📷 구현 영상
사진
영상
✔️ 확인 사항