Refactor : 식단 화면 QA 적용 및 수정 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwoo-jo
added
🎨 DESIGN
m6z1
approved these changes
Mar 26, 2024
| override fun initAfterBinding() { | ||
| val nearestMonday = findNearestMonday(LocalDate.now()) |
There was a problem hiding this comment.
가장 가까운 월요일입니다!
평일일 경우에는 그 주의 월요일, 주말일 경우에는 다음주 월요일을 찾기 위하여 만들었습니다
| @@ -16,6 +19,7 @@ import org.koin.androidx.viewmodel.ext.android.viewModel | |||
| import java.time.DayOfWeek | |||
| import java.time.LocalDate | |||
| import java.time.YearMonth | |||
| import java.time.temporal.TemporalAdjusters | |||
There was a problem hiding this comment.
시간을 조정하기 위한 호출입니다
가장 가까운 월요일을 찾기 위하여 사용합니다
| _menus.postValue(cafeteriaList.find { it.date == selectedDate }?.menus ?: emptyMenu) | ||
| _selectedDate.value = selectedDate | ||
| _menus.postValue( | ||
| cafeteriaList.find { it.date == selectedDate.toString() }?.menus ?: emptyMenu |
There was a problem hiding this comment.
selectedDate를 toString 으로 타입을 변경해야 하는데 selectedDate 자체를 LocalDate 타입으로 변경하신 이유가 궁금해요
There was a problem hiding this comment.
날짜의 변동을 확인하는 CafeteriaInterface의 notifyDateChanged을 위하여 LocalDate를 사용해야합니다. String에서 LocalDate로 변경이 불가능하여 LocalDate 타입으로 수정하였습니다.
There was a problem hiding this comment.
이전에 확인하지 못한 오류라 같이 수정하였습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
✍️ 구현 내용
adapter명에서stu를 제거하여 명확한 변수명으로 수정하였습니다.오늘의 날짜가 주말일 경우 다음 주 월요일로 시작합니다.
Chip의 글자 크기와CardView의 크기를 수정하였습니다.CardView의 그림자 효과를 제거하고 테두리로 변경하였습니다.📷 구현 영상
✔️ 확인 사항