Feat : 온보딩 3단계 키워드 알림 설정 페이지 구현 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeongho <[email protected]>
Co-authored-by: Jeongho <[email protected]>
…ndroid into feature/onboarding-#3
…ndroid into feat/onboarding-#3
…ndroid into feat/onboarding-#3
m6z1
requested changes
Mar 13, 2024
Comment on lines
37
to
49
| binding.switchPermission.setOnCheckedChangeListener { compoundButton, _ -> | ||
| if (compoundButton.isChecked) { | ||
| viewModel.setIsAccessSchoolAlarm(true) | ||
| viewModel.setIsAccessDepartAlarm(true) | ||
| binding.switchPermission.compoundDrawableTintList = | ||
| ColorStateList.valueOf(ContextCompat.getColor(this, R.color.blue300)) | ||
| binding.switchPermission.setTextColor(getColor(R.color.blue300)) | ||
| } else { | ||
| viewModel.setIsAccessSchoolAlarm(false) | ||
| viewModel.setIsAccessDepartAlarm(false) | ||
| binding.switchPermission.compoundDrawableTintList = | ||
| ColorStateList.valueOf(ContextCompat.getColor(this, R.color.gray300)) | ||
| binding.switchPermission.setTextColor(getColor(R.color.gray300)) |
There was a problem hiding this comment.
버튼 눌렀을 때 권한 요청 받는 부분은 아직 구현 안 하신 건가요 ?
There was a problem hiding this comment.
추가로 버튼을 체크했다가 다시 눌렀을 때 isChecked 가 false로 변환 되는 부분이 없는 것 같아요! 영상 보니 다시 switch 버튼을 해제했을 때 알림 아이콘 색상이 변경이 안 되는 것 같네용
There was a problem hiding this comment.
앗 권한 요청까지 수정해서 같이 올리도록 하겠습니다
isChecked는 확인해보도록 하겠습니다
색상 변경은 수정 했는데 제가 수정 전 영상으로 업로드했네요..!!
There was a problem hiding this comment.
권한 설정 부분은 세팅 화면과도 얽혀있어서 개별 작업하는 것이 나을거 같습니다
isChecked와 setIsAccessSchoolAlarm, setIsAccessDepartAlarm은 코드 내에서 반복적으로 사용하여 함수로 분리해보았습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
기존 PR : Feat : 온보딩 3단계 키워드 알림 설정 페이지 구현 #155
✍️ 구현 내용
대학 공지와키워드 공지가 동시에 적용됩니다.알림 설정 및 시작하기→시작하기📷 구현 영상
KakaoTalk_20240314_011306588.mp4
✔️ 확인 사항