Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design : 피그마 색상 등록 #135

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Design : 피그마 색상 등록 #135

merged 1 commit into from
Jan 6, 2024

Conversation

huiwoo-jo
Copy link
Contributor

@huiwoo-jo huiwoo-jo commented Jan 5, 2024 •
edited
Loading

📮 관련 이슈

✍️ 구현 내용

  • 피그마에 등록되어 있는 색상으로 color 색상 등록
  • 테마와 스타일은 아직 수정하지 않았습니다

✔️ 확인 사항

  • 컨벤션에 맞는 PR 타이틀
  • 관련 이슈 연결
  • PR 관련 정보 연결 (작업자, 라벨, 마일스톤 등)
  • Github Action 통과

@huiwoo-jo huiwoo-jo added the 🎨 DESIGN User interface design label Jan 5, 2024
@huiwoo-jo huiwoo-jo self-assigned this Jan 5, 2024
@huiwoo-jo huiwoo-jo requested a review from m6z1 January 5, 2024 14:08
m6z1
m6z1 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@m6z1 m6z1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@m6z1 m6z1 added the 🩵희우 label Jan 5, 2024
hoyahozz
hoyahozz reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@hoyahozz hoyahozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다크모드 팔레트는 아직 안정해졌나요~?

@huiwoo-jo
Copy link
Contributor Author

라이트 모드의 색상만 확정되어 추가했습니다!
색상도 colors 파일에만 추가하였고 themes는 수정 전입니다

@hoyahozz
Copy link
Member

hoyahozz commented Jan 5, 2024

라이트 모드의 색상만 확정되어 추가했습니다! 색상도 colors 파일에만 추가하였고 themes는 수정 전입니다

네 ㅎㅎ 그럼 일단 머지해도 될 것 같아요~ 👍👍👍

@huiwoo-jo huiwoo-jo merged commit 834a6a7 into develop Jan 6, 2024
1 check passed
@huiwoo-jo huiwoo-jo deleted the setting/color branch January 6, 2024 00:27
@m6z1 m6z1 changed the title design : 피그마 색상 등록 Design : 피그마 색상 등록 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoyahozz hoyahozz hoyahozz approved these changes

@m6z1 m6z1 m6z1 approved these changes

Assignees

@huiwoo-jo huiwoo-jo

Labels
🎨 DESIGN User interface design 🩵희우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

컬러 시스템 설정
3 participants
@huiwoo-jo @hoyahozz @m6z1