refactor : 텍스트 클리어 버튼의 기능에 맞는 네이밍 수정

TeamDMU · Feb 5, 2024 · cf670bf · cf670bf
1 parent f10fee0
commit cf670bf
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/app/src/main/java/com/dongyang/android/youdongknowme/ui/view/search/SearchFragment.kt b/app/src/main/java/com/dongyang/android/youdongknowme/ui/view/search/SearchFragment.kt
@@ -67,18 +67,18 @@ class SearchFragment : BaseFragment<FragmentSearchBinding, SearchViewModel>() {
             }
 
             override fun afterTextChanged(s: Editable?) {
-                viewModel.validateSearchContent()
+                viewModel.validateSearchClearButtonVisibility()
             }
         })
 
-        viewModel.searchValidation.observe(viewLifecycleOwner) { isValid ->
-            binding.ivSearchCancel.visibility = if (isValid) View.VISIBLE else View.GONE
+        viewModel.searchClearVisibility.observe(viewLifecycleOwner) { isValid ->
+            binding.ivSearchClear.visibility = if (isValid) View.VISIBLE else View.GONE
         }
     }
 
     private fun setTextClearButtonClickListener() {
         with(binding) {
-            ivSearchCancel.setOnClickListener {
+            ivSearchClear.setOnClickListener {
                 etSearchBar.text.clear()
             }
         }

diff --git a/app/src/main/java/com/dongyang/android/youdongknowme/ui/view/search/SearchViewModel.kt b/app/src/main/java/com/dongyang/android/youdongknowme/ui/view/search/SearchViewModel.kt
@@ -8,10 +8,10 @@ class SearchViewModel : BaseViewModel() {
     private val _searchContent: MutableLiveData<String> = MutableLiveData()
     val searchContent: MutableLiveData<String> = _searchContent
 
-    private val _searchValidation: MutableLiveData<Boolean> = MutableLiveData()
-    val searchValidation: LiveData<Boolean> = _searchValidation
+    private val _searchClearVisibility: MutableLiveData<Boolean> = MutableLiveData()
+    val searchClearVisibility: LiveData<Boolean> = _searchClearVisibility
 
-    fun validateSearchContent() {
-        _searchValidation.value = !_searchContent.value.isNullOrEmpty()
+    fun validateSearchClearButtonVisibility() {
+        _searchClearVisibility.value = !_searchContent.value.isNullOrEmpty()
     }
 }
diff --git a/...rc/main/res/drawable/ic_search_cancel.xml → ...src/main/res/drawable/ic_search_clear.xml b/...rc/main/res/drawable/ic_search_cancel.xml → ...src/main/res/drawable/ic_search_clear.xml
diff --git a/app/src/main/res/layout/fragment_search.xml b/app/src/main/res/layout/fragment_search.xml
@@ -46,18 +46,18 @@
                 android:textColor="@color/blue300"
                 android:textColorHint="@color/gray300"
                 app:layout_constraintBottom_toBottomOf="parent"
-                app:layout_constraintEnd_toEndOf="@id/iv_search_cancel"
+                app:layout_constraintEnd_toEndOf="@id/iv_search_clear"
                 app:layout_constraintStart_toEndOf="@id/iv_search_icon"
                 app:layout_constraintTop_toTopOf="parent" />
 
             <ImageView
-                android:id="@+id/iv_search_cancel"
+                android:id="@+id/iv_search_clear"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:clickable="true"
                 android:focusable="true"
                 android:padding="12dp"
-                android:src="@drawable/ic_search_cancel"
+                android:src="@drawable/ic_search_clear"
                 android:visibility="gone"
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintEnd_toEndOf="parent"