Merge pull request #301 from TeamBeMyPlan/feature/299

[feature] #299 DI 모듈 관련 코드 수정
TeamBeMyPlan · Jun 20, 2022 · c0cab89 · c0cab89
2 parents 93d1fa4 + fb6f7c9
commit c0cab89
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/app/src/main/java/co/kr/bemyplan/data/firebase/FirebaseAnalyticsProvider.kt b/app/src/main/java/co/kr/bemyplan/data/firebase/FirebaseAnalyticsProvider.kt
@@ -6,11 +6,10 @@ import com.google.firebase.analytics.ktx.analytics
 import com.google.firebase.ktx.Firebase
 import javax.inject.Inject
 
-class FirebaseAnalyticsProvider() {
-    @Inject
-    lateinit var beMyPlanDataStore: BeMyPlanDataStore
-
-    val parameters = Bundle().apply {
+class FirebaseAnalyticsProvider @Inject constructor(
+    private val beMyPlanDataStore: BeMyPlanDataStore
+) {
+    private val parameters = Bundle().apply {
         this.putString("device", "Android")
         this.putInt("userId", beMyPlanDataStore.userId)
     }

diff --git a/app/src/main/java/co/kr/bemyplan/di/SingletonModule.kt b/app/src/main/java/co/kr/bemyplan/di/SingletonModule.kt
@@ -25,5 +25,6 @@ object SingletonModule {
 
     @Provides
     @Singleton
-    fun provideFirebaseAnalytics() = FirebaseAnalyticsProvider()
+    fun provideFirebaseAnalytics(beMyPlanDataStore: BeMyPlanDataStore) =
+        FirebaseAnalyticsProvider(beMyPlanDataStore)
 }