ValueProvider observers and PID fixes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcahoon
force-pushed
the
rcahoon/pid-extensions
branch
from
b1a7e4f
to
ce431ab
Compare
rcahoon
force-pushed
the
rcahoon/pid-extensions
branch
from
ce431ab
to
8d2604e
Compare
dejabot
approved these changes
Mar 1, 2024
| configPrefix += "."; | ||
| } | ||
| this.pidController = PIDController.loadFromConfig(configPrefix + "pid."); | ||
| this.pidController = new PIDController(); |
There was a problem hiding this comment.
why not read this from the config file?
There was a problem hiding this comment.
Because the other MotorControllers don't read their PID gains from the config file.
This is now accomplished (more generically and more correctly) by configurePID in RobotProvider
rcahoon
force-pushed
the
rcahoon/pid-extensions
branch
6 times, most recently
from
edda3f7
to
619e804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a system to register for notifications when a
ValueProvider's value changes. Use it in PID gains forMotorControllersAlso a few assorted fixes for #49
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Be detailed so that your code reviewer can understand exactly how much and what kinds of testing were done, and which might still be worthwhile to do.