Code review of main #29

rcahoon · 2023-03-13T03:18:38Z

No description provided.

Changes initially made by VS Code import tool. Updated from there to make sure Maroon Framework continues to build. This change contains a temporary implementation of WPIRobotProvider.hasNewDriverStationData() (underlying method removed in WPILib 2023) until we make a longer-term fix.

Update to WPILib 2023

…metry

Add a background thread (thought in progress) that refreshes data hasNewDriverStationData will compare refresh count with member variable it maintains.

clean up code for WPIRobotProvider move DriverStation.refreshData() to OI (wrapped in new HAL API)

1. rename refreshData() to refreshDriverStationData() for clarity. 2. move context.waitFor(...hasNewDriverStationData()) to top of loop. also fixed some formatting issues in WPIRobotProvider.java

…tationdata Provide new implementation for WPIRobotProvider.hasNewDriverStationData() and update integration in OI

Point developers to new deploy process for configuration files.

This reverts commit 028a5c2.

Reverts commit 1a97891.

…bot code

Fix revert config changes

update deployconfigFiles so it doesn't kill robot code

Candle rev a

…ixConstants

…into fixConstants" This reverts commit c42a655, reversing changes made to 6bf8907.

Fix constants

Swerve documentation

…rison

initial bringup of RevA robot

…n/main-comparison

dejabot and others added 30 commits January 14, 2023 10:27

Initial commit

dd34417

Initialize swerveOdometry

8f2e55d

Merge pull request #1 from Team766/update_wpilib

e90ee7b

Update to WPILib 2023

Merge branch 'main' of https://github.com/Team766/2023 into swerveOdo…

45fc147

…metry

more merges from WPILib 2023 changes

2985ad2

Removed Repeated element from LogListValue

d9b8e58

update implementation of WPIRobotProvider.hasNewDriverStationData().

577a30d

Add a background thread (thought in progress) that refreshes data hasNewDriverStationData will compare refresh count with member variable it maintains.

more fixes for WPILib 2023

b88b9c2

clean up code for WPIRobotProvider move DriverStation.refreshData() to OI (wrapped in new HAL API)

fix formatting

e8b1efb

respond to PR comments

ce537b8

1. rename refreshData() to refreshDriverStationData() for clarity. 2. move context.waitFor(...hasNewDriverStationData()) to top of loop. also fixed some formatting issues in WPIRobotProvider.java

code review feedback: wait then refresh

9d96ed0

Merge pull request #2 from Team766/fix_wpirobotprovider_hasnewdrivers…

2e9ac19

…tationdata Provide new implementation for WPIRobotProvider.hasNewDriverStationData() and update integration in OI

rev Maroon Framework version (#16)

11026a6

Disable editing via /config.

1a97891

Point developers to new deploy process for configuration files.

Fix HTML formatting in /config

028a5c2

Fix PID gain scaling in MotorControllerWithSensorScale

2b119dd

Beacon position sensor for simulator

0550083

Add braces around if bodies

8af12f2

Revert config file changes

e3490bb

This reverts commit 028a5c2.

Revert config file changes

6016427

Reverts commit 1a97891.

Added FollowPoints stopping robot during procdure

651132a

update deployconfigFiles to occur before the deploy task kills the ro…

395cafb

…bot code

Merge pull request #4 from Team766/fix-revert-config-changes

4648c79

Fix revert config changes

Merge pull request #5 from Team766/fix-deploy-config-files

bef4a23

update deployconfigFiles so it doesn't kill robot code

Create pull_request_template.md

b0153e2

Added seperate CANBus compatability (hopefully)

6563d0f

added robot controls

9a242dd

got rid of unnecesary odometry code/fixed errors

3354d2f

Got swerve working with CANivore

0cb799b

BCNOFNeNaMg and others added 30 commits March 4, 2023 14:00

Fixed error resulting from unrecognized partial derivative symbol

94aa5bb

Delete src/main/java/com/team766/robot/Constants directory

7bba535

Deleted empty constant file

27bda14

Merge branch 'RevA' of https://github.com/Team766/2023 into CANdleRevA

78a257d

Added "off" to documentation

e2d84bb

Reset OI

8edac05

Removed matrix from CANdleMech

6d5557e

changed constants name

346e404

Merge branch 'main' into CANdleRevA

e48405e

Merge pull request #24 from Team766/CANdleRevA

58558b3

Candle rev a

Delete src/main/java/com/team766/robot/Constants directory

d19fa73

Delete src/main/java/com/team766/robot/Constants directory

f8b8f0b

fixed constants

6bf8907

Merge branch 'fixConstants' of https://github.com/Team766/2023 into f…

c42a655

…ixConstants

Revert "Merge branch 'fixConstants' of https://github.com/Team766/2023 …

ad146ef

…into fixConstants" This reverts commit c42a655, reversing changes made to 6bf8907.

HEEEEconstants

97f6d84

notHEEEE

35959b9

Merge pull request #25 from Team766/fixConstants

9dfab9a

Fix constants

update build.gradle to 4.2

3918333

Merge branch 'main' of https://github.com/Team766/2023 into SwerveDoc

f1e75a3

Merge branch 'main' of https://github.com/Team766/2023

917093f

Merge pull request #26 from Team766/SwerveDoc

fc9842e

Swerve documentation

initial revA bringup

f4a29a0

initial revA bringup, got drive working

0dfb69c

Remove unnecessary import from OI

2553cdd

Merge remote-tracking branch 'mf/master'

93bee2e

Merge remote-tracking branch 'origin/main' into ryancahoon/main-compa…

7797b9b

…rison

Merge branch 'main' into bringup

923a078

Merge pull request #27 from Team766/bringup

1b726a6

initial bringup of RevA robot

Merge branch 'main' of https://github.com/Team766/2023 into ryancahoo…

ca8cda4

…n/main-comparison

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code review of main #29

Code review of main #29

rcahoon commented Mar 13, 2023

Code review of main #29

Are you sure you want to change the base?

Code review of main #29

Conversation

rcahoon commented Mar 13, 2023