[Feature/#93] compose loading snackbar #97

chanubc · 2024-10-11T04:21:58Z

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

merge할 브랜치의 위치를 확인해 주세요(main❌/develop⭕)
리뷰가 필요한 경우 리뷰어를 지정해 주세요
P1 단계의 리뷰는 필수로 반영합니다.
Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다.

📌 𝗜𝘀𝘀𝘂𝗲𝘀

closed [HOTFIX] : 앰플리튜드의 병목현상에 따른 회원가입 로딩 스낵바 추가 #93

📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

compose custom snackbar
로딩인디케이터 + 팝업 구현
custom drop shadow 구현

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

KakaoTalk_20241011_135724734.mp4

KakaoTalk_20241011_135721618.mp4

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

약관동의화면에서 로딩인디케이터 뜨는 부분은 팝업으로 구현했습니다! 뒷배경이 살짝 안보이는게 좋을 것 같다해서
로딩 되는 동안 모든 액션(백버튼, 스와이프 뒤로가기) 등등 다 막아 놓았는데 백버튼은 허용할까요?

일단 허용했습니다

sohyun127

고생하셨습니다!
백버튼이 하단 백버튼 맞나요?!

sohyun127 · 2024-10-11T05:23:50Z

feature/main-compose/src/main/java/com/teamwable/main_compose/MainScreen.kt

+            val job = launch {
+                snackBarHostState.showSnackbar(getErrorMessage(throwable, localContextResource))
+            }
+            delay(SNACK_BAR_DURATION)


임의로 딜레이 주신 이유가 있을까요?!

토스트는 2초인데 스낵바는 4초라 너무 길다 생각했습니다! 2초로 커스텀하엿는데
어떻게 생각하시나요??

네! 하단 백버튼 맞아요
로딩중에 백버튼 누르면 이미지 압축 및 서버 통신 취소하고 이전 화면으로 돌아가요!

아하!! 2초 좋아요! 백버튼 허용하는 것도 좋아유 👍

sohyun127

고생하셨습니다~!

sohyun127 · 2024-10-11T14:05:55Z

core/network/src/main/java/com/teamwable/network/TokenInterceptor.kt

-                ).apply {
-                    addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP or Intent.FLAG_ACTIVITY_NEW_TASK)
-                },


요건 이제 삭제해도 되나요?!

네! makeRestartActivityTask()자체가 기존 액티비티 스택을 모두 비우고 재시작 하는거라 저건 필요 없는 거 같아요!

실제로 저거 지우나 있으나 똑같더라구요ㅠ

아하 글쿤요 굿 👍

chanubc added 15 commits October 9, 2024 17:37

#93 [add] : add snack bar color

a797ab9

#93 [hotfix] : 누락된 dto필드 추가

087ba4e

Merge branch 'refs/heads/develop' into feature/#93-compose-snackbar

616a35c

#93 [add] : add custom drop shadow

7274f02

#93 [add] : add ProgressBackground color

a7ca426

#93 [add] : set SnackBarType

b1e0238

#93 [feat] : make custom CircularProgressIndicator

ff5a46e

#93 [chore] : set radius_8 dimes

e2c4ce7

#93 [feat] : make custom snackbar with proress indicator and drop shadow

3b3d6a7

#93 [feat] : adjust SnackbarHost position and elevate with zIndex

2598851

#93 [refactor] : error message 함수 분리

2d34aff

#93 [add] : WableSnackBarPopUp 전체화면으로 구현

d887a0e

#93 [chore] : 올바르지 않은 padding 수정

6fd1f16

#93 [feat] : 로딩 스낵 팝업 state 구현

99c885a

#93 [fix] : 스낵바 delay 2초설정

5bb747e

chanubc added the COMPOSE 컴포즈 ui label Oct 11, 2024

chanubc requested a review from a team October 11, 2024 04:21

chanubc self-assigned this Oct 11, 2024

chanubc requested review from Eonji-sw and sohyun127 and removed request for a team October 11, 2024 04:21

#93 [fix] : 백버튼시 작업 취소 허용

6c92cb3

chanubc added the 🐻 찬우 차은우 label Oct 11, 2024

sohyun127 approved these changes Oct 11, 2024

View reviewed changes

chanubc added 6 commits October 11, 2024 20:10

#93 [refacotr] : 로딩 프로필 state 추가

ce594f7

#93 [refactor] : error message로직 common으로 이동

cc704d5

#93 [feat] : profile edit route에서 compose snackbar호출

5e53042

#93 [fix] : LOADING_PROFILE 로딩 인디케이터 뜨도록 수정

e374231

#93 [feat] : 프로필 편집 시 로딩 스낵 팝업 구현

5cce9c1

#93 [fix] : refresh 만료 후 홈화면 진입시 2번 팅겨서 재시작 되는 오류 해결

42a9aa9

chanubc requested a review from sohyun127 October 11, 2024 13:49

#93 [mod] : refresh 시 toast 추가

5a1afc5

chanubc changed the title ~~[Feature/#93] compose snackbar~~ [Feature/#93] compose loading snackbar Oct 11, 2024

sohyun127 approved these changes Oct 11, 2024

View reviewed changes

Merge branch 'refs/heads/develop' into feature/#93-compose-snackbar

8ce5458

chanubc merged commit dad6d76 into develop Oct 11, 2024
1 check passed

chanubc deleted the feature/#93-compose-snackbar branch October 11, 2024 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature/#93] compose loading snackbar #97

[Feature/#93] compose loading snackbar #97

chanubc commented Oct 11, 2024 •

edited

Loading

sohyun127 left a comment

sohyun127 Oct 11, 2024

chanubc Oct 11, 2024

chanubc Oct 11, 2024

sohyun127 Oct 11, 2024

sohyun127 left a comment

sohyun127 Oct 11, 2024

chanubc Oct 11, 2024

sohyun127 Oct 11, 2024

[Feature/#93] compose loading snackbar #97

[Feature/#93] compose loading snackbar #97

Conversation

chanubc commented Oct 11, 2024 • edited Loading

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

📌 𝗜𝘀𝘀𝘂𝗲𝘀

📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

sohyun127 left a comment

Choose a reason for hiding this comment

sohyun127 Oct 11, 2024

Choose a reason for hiding this comment

chanubc Oct 11, 2024

Choose a reason for hiding this comment

chanubc Oct 11, 2024

Choose a reason for hiding this comment

sohyun127 Oct 11, 2024

Choose a reason for hiding this comment

sohyun127 left a comment

Choose a reason for hiding this comment

sohyun127 Oct 11, 2024

Choose a reason for hiding this comment

chanubc Oct 11, 2024

Choose a reason for hiding this comment

sohyun127 Oct 11, 2024

Choose a reason for hiding this comment

chanubc commented Oct 11, 2024 •

edited

Loading