[Feature/#20] : news UI #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eonji-sw
added
๐ย [UI]
sohyun127
reviewed
Aug 17, 2024
feature/news/src/main/java/com/teamwable/news/match/NewsMatchAdapter.kt
Outdated
Show resolved
Hide resolved
feature/news/src/main/java/com/teamwable/news/match/NewsMatchAdapter.kt
Outdated
Show resolved
Hide resolved
feature/news/src/main/java/com/teamwable/news/match/NewsMatchFragment.kt
Show resolved
Hide resolved
| with(binding) { | ||
| tvNewsMatchScoreState.apply { | ||
| when (data.gameStatus) { | ||
| "SCHEDULED" -> { |
There was a problem hiding this comment.
p2 : gamestatus enum class๋ก ํ์ ํํ๋ฉด ๋ถ๊ธฐ์ฒ๋ฆฌ๊ฐ ๋ ๊น๋ํด์ง ๊ฑฐ ๊ฐ์ฌ์ต๋๋ค
There was a problem hiding this comment.
์ด๊ฑฐ ์ธ๋ pr๊น์ง ๋จธ์งํ ๋ด์ ํ ๊ฒ์ฉ ui/type์ ๋ฃ์ผ๋ฉด ๋๋๊น..?
|
|
||
| private fun setTeamProfile(imageView: ImageView, teamName: String) { | ||
| val resourceId = when (teamName) { | ||
| "T1" -> com.teamwable.common.R.drawable.ic_news_team_profile_t1 |
There was a problem hiding this comment.
team label์ ์ ๊ฐ ํ์ ํ ํด๋์์ต๋๋ค -> ์ pr ๋จธ์ง๋๋ฉด ํ์ฉํด๋ณด์ ์
There was a problem hiding this comment.
๋จธ์งํ๊ณ ์ดํ์ ๊ณ ์ณ์ผํ ๊ฒ ๊ฐ์ฌ์ต๋๋ค
feature/news/src/main/java/com/teamwable/news/match/NewsMatchScoreViewHolder.kt
Outdated
Show resolved
Hide resolved
|
์์ ํญํ ์ง๊ธ๋ ๊ด์ถํ๊ฑฐ ๊ฐ์์! |
chanubc
approved these changes
Aug 18, 2024
feature/news/src/main/java/com/teamwable/news/match/NewsMatchScoreAdapter.kt
Outdated
Show resolved
Hide resolved
feature/news/src/main/java/com/teamwable/news/match/NewsMatchScoreViewHolder.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
โ ๐๐ต๐ฒ๐ฐ๐ธ-๐๐ถ๐๐
๐ ๐๐๐๐๐ฒ๐
๐๐ช๐ผ๐ฟ๐ธ ๐๐ฒ๐๐ฐ๐ฟ๐ถ๐ฝ๐๐ถ๐ผ๐ป
๐ท ๐ฆ๐ฐ๐ฟ๐ฒ๐ฒ๐ป๐๐ต๐ผ๐
2024-08-17.10.08.37.mov
2024-08-17.8.31.56.mov
๐ฌ ๐ง๐ผ ๐ฅ๐ฒ๐๐ถ๐ฒ๐๐ฒ๐ฟ๐
์์ง ์๋จ ๋กํฐ ์๋ฃ์์ด๋ค(์ ๋ฒ์ ๋กํฐ ํ๋ฒ์ ๋ฃ๋๋ค๊ณ ๋ค์ด์..)
์์ ํญ์์ ํ? ์์ญ ์์๋ก ํ๋๋ฐ ํผ๊ทธ๋ง๋ฅผ ์ด๋ป๊ฒ ๋ฐ๋ผ์ ํด์ผํ ๊น์ฉ?(์์๋๋ก 1.5, 3.5, 1, 1, 1.5, 1.5๋ก ํจ)