[Setting/#22] datastore 모듈 세팅 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanubc
requested review from
Eonji-sw and
sohyun127
and removed request for
a team
chanubc
changed the base branch from
develop
to
setting/#15-compose-designsystem
sohyun127
approved these changes
Aug 17, 2024
|
|
||
| private suspend fun FlowCollector<Preferences>.handleError(it: Throwable) { | ||
| if (it is IOException) emit(emptyPreferences()) | ||
| else throw it |
There was a problem hiding this comment.
여기서 throw된 exception은 어디서 핸들링 되나요?
There was a problem hiding this comment.
공식문서 복붙 해온거라 그 생각은 못해봤네요!
이 예외는 상위에서 에러핸들링 하라는 의도인것 같습니다.
해당 flow를 viewmodel이나 activity에서 collect하기전 catch문을 통해서 error를 로깅을 찍거나 할수는 있을 것 같아요!
모든 datastore.data에 각 타입별로 default값을 할당 해놓아서 실패시에도 값이 map이 되긴 합니다!
|
|
||
| fun getMemberProfileUrl(): Flow<String> | ||
|
|
||
| fun getIsNewUser(): Flow<Boolean> |
Eonji-sw
approved these changes
Aug 17, 2024
Comment on lines
21
to
28
| val AccessToken = stringPreferencesKey("accessToken") | ||
| val RefreshToken = stringPreferencesKey("refreshToken") | ||
| val Nickname = stringPreferencesKey("nickname") | ||
| val AutoLogin = booleanPreferencesKey("autoLogin") | ||
| val MemberId = intPreferencesKey("memberId") | ||
| val MemberProfileUrl = stringPreferencesKey("memberProfileUrl") | ||
| val IsNewUser = booleanPreferencesKey("isNewUser") | ||
| val IsPushAlarmAllowed = booleanPreferencesKey("isPushAlarmAllowed") |
There was a problem hiding this comment.
key 를 통해서 값을 저장하고 객체를 구성하는 것으로 알고있어서 중요한 부분으로 알고있습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
KakaoTalk_20240817_032146733.mp4
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
datastore는 flow를 저장해야해서
collect 혹은 collectlatest를 통해 값을 가져 오시면 됩니다!