[Feat] 타임 블록 구현 #50
Merged
[Feat] 타임 블록 구현 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuzoo
approved these changes
Jul 9, 2024
Bowoon1216
reviewed
Jul 9, 2024
| @@ -40,7 +39,7 @@ const Input = ( | |||
| return ( | |||
| <article css={containerStyle}> | |||
| {label && <Label id={label}>{label}</Label>} | |||
| <div css={[warpperStyle, variantStyle({ variant, isError }), sizeStyle(size)]}> | |||
| <div css={[warpperStyle, variantStyle(variant, isError), sizeStyle(size)]}> | |||
| justifyContent: 'center', | ||
| alignItems: 'center', | ||
|
|
||
| borderRadius: '10rem', |
There was a problem hiding this comment.
radius는 px로 맞춰주시면 좋을거 같습니다~~ 👍
| const TimeBlock = ({ children, width }: TimeBlockProps) => { | ||
| return ( | ||
| <> | ||
| <div css={[blockStyle, { width: `${width}rem` }]}> |
There was a problem hiding this comment.
blockStyle안에 width를 같이 하지 않은 이유가 있을까용?
There was a problem hiding this comment.
별다른 이유는 없었습니다! 보운님 코리보고 생각해보니 굳이 인라인으로 줄 필요가 없을 것 같아서 blockStyle의 인자로 전달해줬습니다. 감사합니다 :)
cindy-chaewon
approved these changes
Jul 9, 2024
| return ( | ||
| <> | ||
| <div css={[blockStyle, { width: `${width}rem` }]}> | ||
| <Eclipse width={47} height={47} css={{ flexShrink: 0 }} /> |
There was a problem hiding this comment.
css flexShrink 속성은 처음 보네요! 알아갑니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 이슈 번호
closed #37
체크리스트
📌 내가 알게 된 부분
타임 블록 구현
📌 질문할 부분
📌스크린샷 (선택)