-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Pnpm Workspace를 통한 모노레포 도입 #332
Merged
Merged
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
49abb3b
init: pnpm workspace setting, 기존 project -> apps/client
wuzoo 526c632
docs: @tiki/tsconfig package setting
wuzoo fb78649
docs: root dependencies에 따른 하위 패키지 디펜던시 정리
wuzoo 808fdb0
feat: icon package
wuzoo b69f4ac
docs: common hook directory
wuzoo f6e4427
refactor: import error 해결, lib 생성
wuzoo 8f92e94
refactor: utils package 필요한 훅, 함수 이전
wuzoo adf17ac
feat: 기존 project @common/component 를 제공하는 ui package 세팅
wuzoo 9c1c7de
chore: readme root로
wuzoo 4cf235b
refactor: composition 컴포넌트 default export, index 파일 생성
wuzoo a201122
feat: tsup config 작성
wuzoo 928a548
chore: client story ui package 반영
wuzoo 7092a3b
docs: theme, type export 추가
wuzoo c88be36
feat: 모든 기존 코드 @tiki package 반영
wuzoo c197078
init: landing next project setting
wuzoo f218371
chore: svg 수정
wuzoo 229ea55
chore: cachedImage common으로 이동
wuzoo 1177ba9
refactor: navbar Item 컴포넌트 구조 수정 (svg는 icon 패키지로만 사용)
wuzoo 1e762a4
refactor: svgr option no-index 추가
wuzoo 61a1c88
refactor: noEmit 제거 및 tsconfig 수정
wuzoo 9b91d78
docs: tsconfig 수정
wuzoo 37177a0
fix: item 컴포넌트 prop type 반영
wuzoo c12374e
docs: pnpm version match
wuzoo ad68d9c
docs: ci script 수정
wuzoo 5b6c4a7
docs: storybook deploy workflow command 수정
wuzoo f8c1dcd
docs: ci build-storybook scripts 추가
wuzoo a32eb3e
docs: install frozen-lockfile 추가
wuzoo bfa3ec4
chore: ui tsconfig composite 제거
wuzoo f9d7e76
fix: package resolve 문제 alias 추가
wuzoo ba947d6
fix: main.ts @tiki/ui alias 추가
wuzoo 33adf33
chore: icon, utils package 추가
wuzoo ea974d1
fix: preview @tiki/ui/dist 로부터 import
wuzoo 9c5ff3b
fix: preview resolve package issue try 1
wuzoo 60c5aeb
fix: preview resolve package issue try 2
wuzoo 506eced
fix: preview resolve package issue try 3
wuzoo cc09d57
fix: preview resolve package issue try 4
wuzoo 09b4c9a
fix: preview resolve package issue try 5 (optimizeDeps)
wuzoo 7a1252d
fix: preview resolve package issue try 6
wuzoo 89245f1
docs: ui, icon package.json exports 추가
wuzoo 113e78c
fix: preview resolve package issue try 7
wuzoo 003f1fd
fix: preview resolve package issue try 8
wuzoo 66010f5
fix: preview resolve package issue try 9
wuzoo 48bd42f
chore: .npmrc를 통한 symlink 추가
wuzoo a7f4b78
chore: getAbsolutePath, mergeConfig 적용
wuzoo 992c65e
fix: preview resolve package issue try 10
wuzoo 6e125bd
fix: preview resolve package issue try 11
wuzoo 534c4ee
fix: preview resolve package issue try 12
wuzoo 9c2809f
fix: preview resolve package issue try 13
wuzoo cef4e7d
fix: preview resolve package issue try 14
wuzoo df9aa9b
fix: preview resolve package issue try 15
wuzoo 4024f4f
chore: resolve alias 적용, ui package exports 다시 세팅
wuzoo 6fee654
chore: relative path 수정
wuzoo b4a8fdb
chore: icon build script 추가
wuzoo a4e2e25
chore: alias 제거
wuzoo c2a281a
chore: hoisting pattern 추가
wuzoo af9df14
docs: ui, icon build caching
wuzoo 3d240cd
fix: version 오타 수정
wuzoo 3831dd9
chore: node modules caching setting
wuzoo 181df11
docs: storybook deploy workflow 수정
wuzoo 85ac958
chore: 불필요 파일 제거 및 git ignore
wuzoo dfbc8b7
chore: next tsconfig 임시 설정
wuzoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
apps/client/src/page/showcase/index/component/ClubProfileCard/ClubProfileCard.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 0 additions & 31 deletions
31
apps/client/src/shared/component/CachedImage/CachedImage.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스크린 리더기가 이미
img
태그를 이미지로 인식하고 있기 때문에alt
메시지에 -이미지 라는 워딩은 불필요하다고 합니다 ! 참고해서 수정해주심 좋을 것 같아요There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다 !!