[Feat] 대시보드 페이지 timeline date issue 및 css 수정 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namdaeun
reviewed
Nov 14, 2024
|
|
||
| import { PATH } from '@/shared/constant/path'; | ||
|
|
||
| const TimelineSection = () => { | ||
| const TimelineinDash = () => { |
There was a problem hiding this comment.
파스칼 케이스로 작성해주세용 !
그리고 컴포넌트명은 폴더구조가 이미 분리되어 있기 때문에 Timeline으로 해도 괜찮을 것 같은데 어떻게 생각하실까요 ??
rtttr1
approved these changes
Nov 14, 2024
added 2 commits
November 17, 2024 23:06
…to feature/dashboard/#324-timeline-date-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 이슈 번호
closed #324
체크리스트
💎 PR Point
타임라인부분에서 달이 넘어가지 않는 이슈를 타임라인의 내용(Day 컴포넌트 아래)과 헤더부분을 분리함으로 해결했습니다.
내용부분에 useDateContext를 사용해야 했는데, 그러기 위해서는 헤더에 필요한
DateProvider컴포넌트와 분리되어야 하기 때문에 내용 컴포넌트를 분리했습니다.인수인계 부분에서는 첫번째 태그의 글자수가 200픽셀 너비를 넘었을 때 아예 표시되지 않고 숫자만 (ex. '+4') 표시되는 문제가 있어서
보여주는 태그를 선정하는 로직(
getVisibleTags)에 첫번째 태그일 경우 말줄임표와 함께 표시하는 로직을 구현했습니다.📌스크린샷 (선택)
2024-11-12.101518.mp4