Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 팀 탈퇴 기능 구현 #181

Merged
merged 19 commits into from
Dec 2, 2024
Merged

[FEAT] 팀 탈퇴 기능 구현 #181

merged 19 commits into from
Dec 2, 2024

Conversation

paragon0107
Copy link
Contributor

✨ Related Issue

📝 기능 구현 명세

  • 이곳에는 postman 테스트 결과를 넣어주세요

🐥 추가적인 언급 사항

@paragon0107 paragon0107 added the feat 기능 label Nov 29, 2024
@paragon0107 paragon0107 requested a review from Chan531 November 29, 2024 00:22
@paragon0107 paragon0107 self-assigned this Nov 29, 2024
@paragon0107 paragon0107 linked an issue Nov 29, 2024 that may be closed by this pull request
[FEAT] 팀 탈퇴 및 회원 퇴출 기능 구현 #177
Closed
2 tasks
Chan531
Chan531 reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 리뷰 확인해주세요!

src/main/java/com/tiki/server/note/entity/Note.java Outdated Show resolved Hide resolved
src/main/java/com/tiki/server/team/controller/TeamController.java Outdated Show resolved Hide resolved
src/main/java/com/tiki/server/team/service/TeamService.java Outdated Show resolved Hide resolved
src/main/java/com/tiki/server/team/service/TeamService.java Outdated Show resolved Hide resolved
src/main/java/com/tiki/server/team/service/TeamService.java Outdated Show resolved Hide resolved
src/main/java/com/tiki/server/team/service/TeamService.java Outdated Show resolved Hide resolved
src/main/java/com/tiki/server/team/service/TeamService.java Outdated Show resolved Hide resolved
Chan531
Chan531 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! TeamController쪽 응답도 body로 통일해주면 좋을 거 같아요. 다음 pr 때 적용해주시면 좋을 거 같습니다!

@paragon0107 paragon0107 merged commit 33d88c9 into develop Dec 2, 2024
1 check passed
@paragon0107 paragon0107 deleted the feat/#177-kick-out-member branch December 2, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chan531 Chan531 Chan531 approved these changes

Assignees

@paragon0107 paragon0107

Labels
feat 기능
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 팀 탈퇴 및 회원 퇴출 기능 구현
2 participants
@paragon0107 @Chan531