#27 [FEAT] 프로젝트 등록 API 개발 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeseul106
approved these changes
Jul 17, 2023
| } | ||
|
|
||
| public String convertReviewCycleToString(String[] array) { | ||
| if (array == null || array.length == 0) { |
There was a problem hiding this comment.
p4;
array.isEmpty()로 하면 더 깔끔할 것 같습니다 !
|
|
||
| public String convertReviewCycleToString(String[] array) { | ||
| if (array == null || array.length == 0) { | ||
| return ""; |
There was a problem hiding this comment.
p4;
사실 dto 단에서 @NotEmpty 어노테이션으로 validation을 하기 때문에 이 배열이 비어있을 경우, 거기서 에러가 던져지므로 이 if문은 없어도 될 것 같아요 ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Related Issue
📝 Summary
🙏 Question & PR point
📬 Reference