Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13 [FEAT] 이전 회고 템플릿 형식 조회 성공 #24

Merged
merged 1 commit into from
Jul 16, 2023
Merged

#13 [FEAT] 이전 회고 템플릿 형식 조회 성공 #24

merged 1 commit into from
Jul 16, 2023

Conversation

yeseul106
Copy link
Member

@yeseul106 yeseul106 commented Jul 16, 2023 •
edited
Loading

📣 Related Issue

📝 Summary

  • 유저 프로젝트 테이블에서 memberId와 projectId로 해당 유저가 참여한 프로젝트를 찾고, 그 데이터 안에서 가장 최근에 작성한 회고의 템플릿 id 값을 내려주는 API를 구현했습니다.
image

🙏 Question & PR point

📬 Reference

@yeseul106 yeseul106 self-assigned this Jul 16, 2023
Hong0329
Hong0329 approved these changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@Hong0329 Hong0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~~!!

...ver/src/main/java/com/puzzling/puzzlingServer/api/review/service/Impl/ReviewServiceImpl.java
Comment on lines +121 to 124
private UserProject findUserProjectByMemberIdAndProjectId (Long memberId, Long projectId) {
return userProjectRepository.findByMemberIdAndProjectId(memberId,projectId)
.orElseThrow(() -> new NotFoundException("해당하는 멤버가 참여하는 프로젝트가 아닙니다."));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5
알려주셔서 감사합니다.

@yeseul106 yeseul106 merged commit 7abc910 into develop Jul 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hong0329 Hong0329 Hong0329 approved these changes

@qkrwjdan qkrwjdan Awaiting requested review from qkrwjdan

Assignees

@yeseul106 yeseul106

Labels
✨ FEAT ✨ 🐼 예슬 🐼
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 이전 회고 템플릿 조회 API
2 participants
@yeseul106 @Hong0329