Skip to content

Conversation

@GabrielCosme
Copy link
Member

No description provided.

@GabrielCosme GabrielCosme requested a review from Copilot May 15, 2025 04:03

This comment was marked as outdated.

@GabrielCosme GabrielCosme force-pushed the feature/solving-graph branch from d2b294d to f891be8 Compare May 18, 2025 23:35
@GabrielCosme GabrielCosme force-pushed the feature/solving-graph branch from 2bb01e4 to faf6f7d Compare May 19, 2025 02:33
@GabrielCosme GabrielCosme force-pushed the feature/solving-graph branch from faf6f7d to 10db7ad Compare May 19, 2025 02:37
@GabrielCosme GabrielCosme force-pushed the feature/solving-graph branch 3 times, most recently from 09d9c8f to 10b3e7a Compare May 19, 2025 17:09
@GabrielCosme GabrielCosme force-pushed the feature/solving-graph branch from c7a20a4 to 0fc5d20 Compare May 24, 2025 08:47
@GabrielCosme GabrielCosme force-pushed the feature/solving-graph branch from b9e7e5d to ba45531 Compare May 24, 2025 23:55
Base automatically changed from feature/maze-algorithms to main June 7, 2025 23:39
@GabrielCosme GabrielCosme marked this pull request as ready for review June 8, 2025 00:28
@GabrielCosme GabrielCosme requested a review from Copilot June 8, 2025 00:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors navigation components to support graph solving and dynamic motion parameters, including updating pose utilities, wall-follow logic, action definitions, FSM naming, and configuration constants.

  • Added get_relative_side and hash specialization for GridPose
  • Reworked FollowWall, TurnAction, MoveAction, and ActionQueuer APIs to use Config structs and time-based control
  • Renamed FSM to Fsm, updated interface events, and refreshed constants and settings

Reviewed Changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
grid_pose.hpp Added get_relative_side and hash for GridPose
follow_wall.hpp Updated FollowWall config and methods
costmap.hpp Changed WallState to enum class
actions/*.hpp Refactored TurnAction and MoveAction with configs
base.hpp Enhanced Action base to include IDs and timing
action_queuer.hpp Expanded ActionQueuer for graph-based sequences
pid_controller.cpp / .hpp Added first_run to PID and initialization logic
fsm.cpp / fsm.hpp Renamed FSM to Fsm and updated references
utils.hpp Changed move_towards to use std::clamp
interface.hpp Extended events and dip switch state tracking
constants.hpp Tweaked motion parameters and added new constants
.vscode/settings.json Cleaned up VSCode settings
Comments suppressed due to low confidence (4)

micras_nav/include/micras/nav/grid_pose.hpp:55

  • The to_point method signature takes a GridPoint parameter but the docblock lacks @param grid_point; please add and document this parameter for clarity.
* @param cell_size The size of the grid cells.

micras_nav/include/micras/nav/costmap.hpp:29

  • Converting WallState from a plain enum to enum class is an API-breaking change; ensure all uses of WallState are fully qualified (e.g., WallState::WALL) and update any unscoped references.
enum class WallState : uint8_t {

.vscode/settings.json:17

  • It looks like the closing ] and comma for fileOrder may be misplaced after removing the clangd.arguments block; please verify the JSON remains valid.
"doxdocgen.file.fileOrder": [

micras_nav/include/micras/nav/action_queuer.hpp:60

  • The push_exploring signature now uses origin_pose but the doc still refers to current_pose; please update parameter names in the docblock to match the code.
* @param current_pose Current pose of the robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants