-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/solving graph #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Pedro de Santi <[email protected]>
Co-authored-by: Pedro de Santi <[email protected]>
Co-authored-by: Pedro de Santi <[email protected]>
Co-authored-by: Pedro de Santi <[email protected]>
Co-authored-by: Pedro de Santi <[email protected]>
d2b294d to
f891be8
Compare
2bb01e4 to
faf6f7d
Compare
faf6f7d to
10db7ad
Compare
09d9c8f to
10b3e7a
Compare
c7a20a4 to
0fc5d20
Compare
b9e7e5d to
ba45531
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors navigation components to support graph solving and dynamic motion parameters, including updating pose utilities, wall-follow logic, action definitions, FSM naming, and configuration constants.
- Added
get_relative_sideand hash specialization forGridPose - Reworked
FollowWall,TurnAction,MoveAction, andActionQueuerAPIs to use Config structs and time-based control - Renamed
FSMtoFsm, updated interface events, and refreshed constants and settings
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| grid_pose.hpp | Added get_relative_side and hash for GridPose |
| follow_wall.hpp | Updated FollowWall config and methods |
| costmap.hpp | Changed WallState to enum class |
| actions/*.hpp | Refactored TurnAction and MoveAction with configs |
| base.hpp | Enhanced Action base to include IDs and timing |
| action_queuer.hpp | Expanded ActionQueuer for graph-based sequences |
| pid_controller.cpp / .hpp | Added first_run to PID and initialization logic |
| fsm.cpp / fsm.hpp | Renamed FSM to Fsm and updated references |
| utils.hpp | Changed move_towards to use std::clamp |
| interface.hpp | Extended events and dip switch state tracking |
| constants.hpp | Tweaked motion parameters and added new constants |
| .vscode/settings.json | Cleaned up VSCode settings |
Comments suppressed due to low confidence (4)
micras_nav/include/micras/nav/grid_pose.hpp:55
- The
to_pointmethod signature takes aGridPointparameter but the docblock lacks@param grid_point; please add and document this parameter for clarity.
* @param cell_size The size of the grid cells.
micras_nav/include/micras/nav/costmap.hpp:29
- Converting
WallStatefrom a plain enum toenum classis an API-breaking change; ensure all uses ofWallStateare fully qualified (e.g.,WallState::WALL) and update any unscoped references.
enum class WallState : uint8_t {
.vscode/settings.json:17
- It looks like the closing
]and comma forfileOrdermay be misplaced after removing theclangd.argumentsblock; please verify the JSON remains valid.
"doxdocgen.file.fileOrder": [
micras_nav/include/micras/nav/action_queuer.hpp:60
- The
push_exploringsignature now usesorigin_posebut the doc still refers tocurrent_pose; please update parameter names in the docblock to match the code.
* @param current_pose Current pose of the robot.
No description provided.