[FEAT/#75] 아워, 마이 투두 조회, 생성, 삭제 / 서버통신 구현 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/#75-todo-detail-api
chattymin
approved these changes
Jan 12, 2024
Comment on lines
+20
to
+24
| ): NonDataBaseResponse<Unit> | ||
|
|
||
| suspend fun deleteTodoData( | ||
| todoId: Long | ||
| ): NonDataBaseResponse<Unit> |
There was a problem hiding this comment.
요거 다시 보니까 T를 안쓰는데 T를 받아오더라구여!
그래서 NoDataBaseResponse에서 NoDataBaseResponse로 수정했습니다! 조만간 올릴텐데 그때 맞춰서 수정하면 좋을 것 같아용~
| @@ -51,9 +51,10 @@ class SettingLogoutDialogFragment() : | |||
| private fun observeUserSignOutState() { | |||
| viewModel.userSignOutState.flowWithLifecycle(lifecycle).onEach { state -> | |||
| when (state) { | |||
| EnumUiState.LOADING -> {} | |||
There was a problem hiding this comment.
{} 처리하는 것과 return@onEach 하는 것의 차이가 뭔가요???
지금까지 {}로 했는데 불필요한 내용을 실행하지 않는다는 의미로 return@onEach이 더 맞는거 같다는생각이 들었습니당
There was a problem hiding this comment.
밑에는 return@onEach로 되어있네요! 하나로 통일하면 더 좋을 것 같습니다 :)
There was a problem hiding this comment.
{} 제 파일 아님요 ㅋㅋ
저는 그냥 {}에 주황 밑줄 그어지는거 싫어서 리턴해버림
| viewModel.checkIsFinishAvailable() | ||
| dismiss() | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| const val TWO_DIGIT_FORMAT = "%02d" |
…into feat/#75-todo-detail-api
crownjoe
approved these changes
Jan 12, 2024
| @POST("api/trips/{tripId}/todos") | ||
| suspend fun postToCreateTodo( | ||
| @Path("tripId") tripId: Long, | ||
| @Body request: TodoCreateRequestDto |
| viewModel.endDate.value = | ||
| binding.dpCreateTripDate.year.toString() + "." + (binding.dpCreateTripDate.month + 1).toString() + "." + binding.dpCreateTripDate.dayOfMonth.toString() | ||
| binding.dpCreateTripDate.year.toString() + "." + createdMonth + "." + createdDay |
leeeyubin
approved these changes
Jan 12, 2024
Comment on lines
+25
to
+27
| request: TodoCreateRequestDto | ||
| ): NonDataBaseResponse<Unit> = | ||
| todoService.postToCreateTodo(tripId, request) |
Comment on lines
+70
to
+73
|
|
||
| private fun getTodoId() { | ||
| todoId = intent.getLongExtra(EXTRA_TODO_ID, 0) | ||
| } |
| viewModel.checkIsFinishAvailable() | ||
| dismiss() | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| const val TWO_DIGIT_FORMAT = "%02d" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-01-12-10-46-00.mp4
📢 To Reviewers