Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/#66] 여행 친구 조회 뷰 / UI 수정 #72

Merged
merged 12 commits into from
Jan 10, 2024

Conversation

leeeyubin
Copy link
Member

⛳️ Work Description

  • 여행 친구 조회 뷰 UI
  • 여행 멤버 조회 리사이클러뷰
  • 프로그래스바 구현 (반대로도 진행상황 파악할 수 있게)

📸 Screenshot

default.mp4

📢 To Reviewers

  • 아직 API 연결을 안 해서 프로그레스바 로직만 구현해보았어요! 수정할 겁니당

추가로 다른 뷰들도 수정했는데

  • 설정 뷰 layout 눌렀을 때 버튼 클릭 리스너 발생하게 수정,
  • 아워투두 뷰 리사이클러뷰 수정했습니다.

Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고치세요...

@@ -55,7 +55,7 @@

<activity
android:name="com.going.presentation.todo.TodoActivity"
android:exported="false"
android:exported="true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 좀...

Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅎㅎ 다시다시 ㅎㅎ

@@ -55,7 +55,7 @@

<activity
android:name="com.going.presentation.todo.TodoActivity"
android:exported="false"
android:exported="true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋ ㅎㅎ pr 올릴 때는 false 부탁해요 ^^

Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 그냥 어프루브 요청하지 마세요 안봐도 될거같으니깐 ;;

Comment on lines +17 to +21
val position = parent.getChildAdapterPosition(view)

if (position == parent.adapter?.itemCount?.minus(1)) {
outRect.right = 150
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

데코레이션마저 자유자재 ㄷㄷ

Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유빈아 이제 어프루브 안받아도 바로 머지해도 될 듯 ㅋㅋ

G리네 빈g노....

수고해써요!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Comment on lines +42 to +64
private fun setProgressBarStatus() {
// styleA의 평균 값이 1이라고 가정
binding.progressBarCheckFriends1.progress = 1
if (binding.progressBarCheckFriends1.progress <= 2) {
// 평균 값이 0 ~2면 1 더하기
binding.progressBarCheckFriends1.progress = 1 + 1
binding.progressBarCheckFriends2.progress = 2 + 1
binding.progressBarCheckFriends3.progress = 0 + 1
}

// styleD의 평균 값이 3이라고 가정
binding.progressBarCheckFriends4.progress = 3
if (binding.progressBarCheckFriends4.progress > 2) {
// 프로그레스바 반대 방향으로 적용
binding.progressBarCheckFriends4.visibility = View.INVISIBLE
binding.progressBarCheckFriends4Revert.visibility = View.VISIBLE

binding.progressBarCheckFriends5.visibility = View.INVISIBLE
binding.progressBarCheckFriends5Revert.visibility = View.VISIBLE

// 평균 값이 4 ~5 라면 2 빼기
binding.progressBarCheckFriends4Revert.progress = 3 - 2
binding.progressBarCheckFriends5Revert.progress = 4 - 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지리네 유빈지노

이거를 해냈다~~~~~~~~~

@leeeyubin leeeyubin merged commit 7c5e97f into develop Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] 여행 친구 조회 뷰 / UI 구현
3 participants