Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/#267] 세연 담당 뷰 / 2차 QA 이슈 대응 #269

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

crownjoe
Copy link
Contributor

⛳️ Work Description

  • 네이밍 수정
  • qa 반영 (여행 정보 수정 후 뒤로가기 누르면 이전 여행 이름이 수정 페이지에 노출, 근데 우리여행가면 바뀌어 있음, 근데 여행 대시보드 가면 다시 안 바뀌어 있음)

📸 Screenshot

📢 To Reviewers

  • 헤헷

@crownjoe crownjoe added 세연 🤤 FIX 🔨 버그 및 오류 해결 labels Mar 22, 2024
@crownjoe crownjoe added this to the 2차 스프린트 milestone Mar 22, 2024
@crownjoe crownjoe self-assigned this Mar 22, 2024
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿티비~

@@ -78,6 +78,14 @@ class DashBoardActivity :
}
}

private fun setChangeTripInfo() {
val progress = DashBoardViewModel.COMPLETED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 친구 따로 변수화 해주는 이유가 있나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 요 아이는 이것저것 해보다가 작성해놓고 안쓰이는 함수여서 없앴씁니다..

Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿!

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정까지 최고~~~

Comment on lines +129 to +134
private fun sendTripId() {
Intent(requireActivity(), DashBoardActivity::class.java).apply {
putExtra(TRIP_ID, viewModel.tripId)
startActivity(this)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 조아요!!!

@crownjoe crownjoe merged commit 7d97114 into develop Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX 🔨 버그 및 오류 해결 세연 🤤
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 세연 담당 뷰 / 2차 QA 이슈 대응
4 participants