Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/#265] Todo / 2차 QA 이슈 대응 #266

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

Marchbreeze
Copy link
Member

@Marchbreeze Marchbreeze commented Mar 21, 2024

⛳️ Work Description

2024-03-21_15-48-25

📢 To Reviewers

  • 레이아웃 조정하면서 여행 정보쪽 조금 건드렷서요 ~
  • 여행 정보 뷰에서 뷰모델이 with(binding)때문에 레이아웃 뷰모델을 가져오는 부분이 있길래 레이아웃뷰모델 수정했음!

@Marchbreeze Marchbreeze added 상호 🍀 FIX 🔨 버그 및 오류 해결 labels Mar 21, 2024
@Marchbreeze Marchbreeze added this to the 2차 스프린트 milestone Mar 21, 2024
@Marchbreeze Marchbreeze self-assigned this Mar 21, 2024
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

두말할거 없이 깔끔하네요~

Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿👍 네이밍 수정 제가. ㅎㅎ 하겟숨다 하하 여행 수정 감사합니돨!!!

Comment on lines -53 to +55
tvEditTripName.text = viewModel?.title
tvEditTripInfoStartDate.text = viewModel?.startDate
tvEditTripInfoEndDate.text = viewModel?.endDate
viewModel?.gettitleLength()
tvEditTripName.text = viewModel.title
tvEditTripInfoStartDate.text = viewModel.startDate
tvEditTripInfoEndDate.text = viewModel.endDate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요아이!...배워갑니닷 👍👍

@Marchbreeze Marchbreeze merged commit e819ca1 into develop Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX 🔨 버그 및 오류 해결 상호 🍀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] Todo / 2차 QA 이슈 대응
3 participants