[FIX/#252] QA사항 구현 #260
Merged
[FIX/#252] QA사항 구현 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crownjoe
approved these changes
Mar 13, 2024
| @@ -56,7 +56,8 @@ | |||
| <activity | |||
| android:name="com.going.presentation.onboarding.signup.SignUpActivity" | |||
| android:exported="false" | |||
| android:screenOrientation="portrait" /> | |||
| android:screenOrientation="portrait" | |||
| android:windowSoftInputMode="adjustResize" /> | |||
| @@ -6,15 +6,15 @@ | |||
| <string name="to_string">%s</string> | |||
| <string name="dummy">Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</string> | |||
|
|
|||
| <string name="server_error">서버 통신에 실패했습니다</string> | |||
| <string name="server_error">서버 통신에 실패했어요</string> | |||
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| <string name="sign_in_tv_terms">개인정보처리방침</string> | |||
|
|
|||
| <string name="toast_back_pressed">버튼을 한번 더 누르면 종료됩니다</string> | |||
| <string name="toast_back_pressed">버튼을 한번 더 누르면 종료돼</string> | |||
There was a problem hiding this comment.
오잉 근데 이친구 반말해요?......... 허걱
| ).apply { startActivity(this) } | ||
| ).apply { | ||
| startActivity(this) | ||
| finish() |
leeeyubin
approved these changes
Mar 13, 2024
Comment on lines
+29
to
+30
| 7 -> R.drawable.img_profile_3 | ||
| else -> R.drawable.img_profile_guest |
| <string name="trip_profile_character">나의 여행 캐릭터</string> | ||
| <string name="trip_profile_tag">여행 취향 태그</string> | ||
|
|
||
| <!--participant_profilt --> | ||
| <string name="participant_profile_btn">여행 캐릭터 검사하러 가기</string> | ||
| <string name="participant_profile_common">여행 캐릭터 검사를 아직 진행하지 않았어요</string> | ||
| <string name="participant_profile_owner">지금 바로 나를 대신 할 여행 캐릭터를 만나보세요!</string> | ||
| <string name="participant_profile_friend_title">%s의 여행 프로필</string> | ||
| <string name="participant_profile_friend_title">친구 여행 프로필</string> |
crownjoe
reviewed
Mar 13, 2024
| @@ -257,7 +257,7 @@ | |||
| <string name="edit_trip_info_date">%1$d.%2$d.%3$d</string> | |||
| <string name="edit_trip_info_toast_error">시작일을 먼저 입력해 주세요</string> | |||
| <string name="edit_trip_info_quit_dialog_title">여행방 나가기</string> | |||
| <string name="edit_trip_info_quit_dialog_message">나가기를 하면 정보가 모두 삭제되고,\n 여행 목록에서도 삭제됩니다</string> | |||
| <string name="edit_trip_info_quit_dialog_message">나가기를 하면 정보가 모두 삭제되고,\n 여행 목록에서도 삭제돼</string> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers