[FIX/#257] 유빈 담당 뷰 / QA 이슈 대응 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crownjoe
approved these changes
Mar 13, 2024
Comment on lines
+39
to
+44
| override fun onResume() { | ||
| super.onResume() | ||
|
|
||
| setTravelerName() | ||
| } | ||
|
|
| @@ -10,7 +10,7 @@ | |||
| <androidx.constraintlayout.widget.ConstraintLayout | |||
| android:layout_width="match_parent" | |||
| android:layout_height="match_parent" | |||
| android:background="@color/white_000" | |||
| android:background="@color/gray_50" | |||
Comment on lines
65
to
69
| fun checkIsPreferenceChange(number: Int, index: Int) { | ||
| when (number) { | ||
| 1 -> { | ||
| styleA.value = index | ||
| isStyleAChanged = index != defaultStyleA.value |
chattymin
approved these changes
Mar 13, 2024
Comment on lines
30
to
40
| private val defaultStyleA = MutableLiveData(0) | ||
| private val defaultStyleB = MutableLiveData(0) | ||
| private val defaultStyleC = MutableLiveData(0) | ||
| private val defaultStyleD = MutableLiveData(0) | ||
| private val defaultStyleE = MutableLiveData(0) | ||
|
|
||
| private val styleA = MutableLiveData(0) | ||
| private val styleB = MutableLiveData(0) | ||
| private val styleC = MutableLiveData(0) | ||
| private val styleD = MutableLiveData(0) | ||
| private val styleE = MutableLiveData(0) |
There was a problem hiding this comment.
혹시 이걸 전부 다 observe 혹은 데바에 쓰고있나요?
그게 아니라면 mutableLiveData일 필요는 없을 것 같습니다!!
단순히 값을 저장하기 위함이라면 val 혹은 var로도 충분합니당 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
이번 여행은!header underline 추가하기📸 Screenshot
Screen_Recording_20240314_005935_doorip.mp4
Screen_Recording_20240314_005638_doorip.mp4
📢 To Reviewers