Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD/#16] 타이포, 색상 에셋 수정, 로고 추가 #17

Merged
merged 3 commits into from
Jan 1, 2024
Merged

[ADD/#16] 타이포, 색상 에셋 수정, 로고 추가 #17

merged 3 commits into from
Jan 1, 2024

Conversation

Marchbreeze
Copy link
Member

⛳️ Work Description

  • 타이포 확정본으로 수정
  • 색상 확정본으로 수정
  • doorip 로고 추가

📢 To Reviewers

  • 이거 어프루브하면 이거 쓰면서 그대로 UI 작업 시작하셔도 됩니당 ~

@Marchbreeze Marchbreeze added 상호 🍀 ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 labels Jan 1, 2024
@Marchbreeze Marchbreeze added this to the 프로젝트 초기 세팅 milestone Jan 1, 2024
@Marchbreeze Marchbreeze self-assigned this Jan 1, 2024
chattymin
chattymin approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 깰끔 상호! 귀찮은 일인데 먼저 해주셔서 감사합니다 👍

presentation/src/main/res/values/colors.xml
<color name="red_400">#FE6032</color>
<color name="red_500">#FF4F17</color>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디자인굉굉이네 공유방 -> Hi-fi view에는 red_400이 FF4F17 로 되어있는데 여기는 red_500으로 되어있어요!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 그 아래에 브랜딩 페이지 보면 red_400이 없어졌슴니다..! 요거는 디잔 측에 요청해서 통일해달라구 해야할듯

@Marchbreeze Marchbreeze merged commit 82df2cc into develop Jan 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chattymin chattymin chattymin approved these changes

@leeeyubin leeeyubin Awaiting requested review from leeeyubin

@crownjoe crownjoe Awaiting requested review from crownjoe

Assignees

@Marchbreeze Marchbreeze

Labels
ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 상호 🍀
Projects
None yet
Milestone
프로젝트 초기 세팅
Development

Successfully merging this pull request may close these issues.

[ADD] 타이포 에셋, 로고 추가
2 participants
@Marchbreeze @chattymin