[UI/#13] onboarding profile setting #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
approved these changes
Jan 1, 2024
Comment on lines
32
to
35
| binding.etvOnboardingProfileSettingOnLineInfo.setOnEditorActionListener { view, actionId, _ -> | ||
| if (actionId == EditorInfo.IME_ACTION_DONE) view.clearFocus() | ||
| false | ||
| } |
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 어우 컴포넌트 id 한번 살벌하네요 ㅋㅋㅋㅋㅋ
우리 에딧텍스트 컨벤션 et로 설정해주셔야할 듯 하구, 지금도 괜찮지만 조오금은 길이 줄여볼 방법도 생각해보면 좋을듯 ㅎㅎ
Comment on lines
56
to
57
| const val MAX_NAME_LEN = 5 | ||
| const val MAX_INFO_LEN = 20 |
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| app:title="@string/onboarding_title" |
There was a problem hiding this comment.
이거 저는 액티비티에서의 추출과 xml에서의 추출을 구분하기 위해 onboarding_tb_title 처럼 컴포넌트 유형도 넣어주는 편입니다!
| <string name="onboarding_name">이름을 입력해주세요.</string> | ||
| <string name="onboarding_one_line_info_title">한줄 소개</string> | ||
| <string name="onboarding_one_line_info">당신을 한줄로 표현해보세요.</string> | ||
| <string name="onboarding_finish_button">유형 검사하러 가기</string>] |
Comment on lines
14
to
16
| <item name="colorControlActivated">@color/red_600</item> | ||
| </style> |
There was a problem hiding this comment.
복붙의...폐헤입니다... 왜 안바꿨지...
죄송함다 ㅠㅠ
…g' into ui/#13-onboarding-profile-setting # Conflicts: # presentation/src/main/res/values/strings.xml
Marchbreeze
approved these changes
Jan 1, 2024
Comment on lines
42
to
51
| binding.etOnboardingProfileSettingName.setOnFocusChangeListener { _, hasFocus -> | ||
| if (hasFocus) { | ||
| setNameCounterColor(R.color.gray_700) | ||
| } else { | ||
| setNameCounterColor(R.color.gray_200) | ||
| } | ||
| if (viewModel.isNameAvailable.value == NameState.Blank) { | ||
| setNameCounterColor(R.color.red_400) | ||
| } | ||
| } |
There was a problem hiding this comment.
아래랑 똑같이 반복되는거 함수화해서 간략하게 할수도 있어보여요!
| @@ -0,0 +1,19 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <selector | |||
Comment on lines
+65
to
+66
| android:textColor="@{viewModel.isNameAvailable() == NameState.Blank ? @color/red_400 : @color/gray_700}" | ||
| android:visibility="@{viewModel.isNameAvailable() == NameState.Blank ? View.VISIBLE : View.GONE}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
2024-01-01.9.05.38.mov
📢 To Reviewers