[FEAT]/#92 여행 입장 뷰 / 서버통신 구현 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/#92-enter-trip-api
chattymin
approved these changes
Jan 14, 2024
| @@ -32,6 +34,7 @@ class InviteFinishActivity : | |||
| val serverlist = getIntent() | |||
|
|
|||
| if (serverlist != null) { | |||
| tripId = intent.getLongExtra("tripId", -1L) | |||
There was a problem hiding this comment.
tripId와 같이 사용해야 하는 것은 companion object로 빼주세용~
Comment on lines
88
to
90
| Intent(this, DashBoardActivity::class.java).apply { | ||
| startActivity(this) | ||
| } |
There was a problem hiding this comment.
함수화 합시다!
navigatetoDashBoard 처럼 네이밍을 하면 좋겠네용~
| ) | ||
| .onSuccess { | ||
| _finishInviteState.value = UiState.Success(it) | ||
| Log.d("cho", styleA.value.toString()) |
There was a problem hiding this comment.
아차차차차차 바로 수정하겟습니다.............
Marchbreeze
approved these changes
Jan 14, 2024
| @@ -92,6 +92,7 @@ class EnterTripActivity : BaseActivity<ActivityEnterTripBinding>(R.layout.activi | |||
| is UiState.Success -> { | |||
|
|
|||
| Intent(this, InviteFinishActivity::class.java).apply { | |||
| putExtra("tripId", state.data.tripId) | |||
There was a problem hiding this comment.
요것도 다른 엑스트라처럼 모아서 const val로 설정해주시면 좋을듯 ~
|
더미데이터가 인상적이네요 (? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240114_205906_doorip.mp4
📢 To Reviewers