Skip to content

Conversation

surfing2003
Copy link
Collaborator

@surfing2003 surfing2003 commented Jul 29, 2022

Changes?

템플릿 패턴을 위한 코드 추가

Why we need?

템플릿 패턴 학습

Test?

template_test.py 를 통해 테스트

Checklist

  • Assignees updated the README, if necessary.
  • Assignees checked the runnability of the code.
  • Reviewers checked the runnability of the code.

Anything Else? (Optional)

테스트 코드를 pytest를 활용하는 형태로 변경

@github-actions github-actions bot added the size/L 110+ lines are updated label Jul 29, 2022
@Kimdongui Kimdongui added feature Some features are implemented and removed need-to-change-branch-name labels Jul 31, 2022
Copy link
Member

@Kimdongui Kimdongui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abstract_beverage.py general_beverage.py와 같이 두 파일로 따로 구현하는 방식은 어떨까요??

@github-actions github-actions bot added need-to-change-branch-name and removed feature Some features are implemented labels Aug 1, 2022
@Kimdongui Kimdongui added feature Some features are implemented and removed need-to-change-branch-name labels Aug 1, 2022
@surfing2003
Copy link
Collaborator Author

abstract_beverage.py general_beverage.py와 같이 두 파일로 따로 구현하는 방식은 어떨까요??

다른 코드도 작업할 때도 몰아서 작업해서 이것도 몰아서 작업하긴 했는데 분리하는게 좋을까요?

@Kimdongui
Copy link
Member

abstract_beverage.py general_beverage.py와 같이 두 파일로 따로 구현하는 방식은 어떨까요??

다른 코드도 작업할 때도 몰아서 작업해서 이것도 몰아서 작업하긴 했는데 분리하는게 좋을까요?

네네! 아니면 분리하는 코드는 제가 한번 짜볼까요??

@Gangsss
Copy link
Collaborator

Gangsss commented Aug 21, 2022

@Kimdongui 동현님 코드 짜신 후에 리뷰하겠습니다.

@Kimdongui Kimdongui marked this pull request as draft August 29, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Some features are implemented size/L 110+ lines are updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants