Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config added: Per server/library configuration example and instructions. #1814

Merged
merged 9 commits into from
Feb 22, 2024

Conversation

SebbeJohansson
Copy link
Contributor

@SebbeJohansson SebbeJohansson commented Feb 20, 2024

  • Adds instructions on how to setup configuration per server and per library.
  • Adds examples of how to setup configuration per server and per library.
  • Adds instructions and examples of how to schedule with ofilia if multiple servers are used.

Fixes #1808

@SebbeJohansson
Copy link
Contributor Author

As discussed in: #1808

README.md Outdated Show resolved Hide resolved
README.md Outdated
ofelia.job-run.plextraktsync2.container: "plextraktsync"
ofelia.job-run.plextraktsync2.command: "--server 'Example2' sync"
```
This means that a job is running every 6 hours, alternating between the two "servers". Keep in mind that since this example assumes that you are only running one container, you need to make sure that the jobs don't overlap.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why jobs can't overlap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because if the job takes a long time (say over half a second) Ofelia doesn't want to create the same container again. Maybe there is a cleaner way? Not super used to Ofelia.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, that just means it runs only one job at a time.

either remove the warning, or explain what it's for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea true. Ive rewritten it and extended it with some further information! Let me know what you think! 😄

@glensc
Copy link
Collaborator

glensc commented Feb 21, 2024

general note: it should be noted that the server configs override global config.yml

@SebbeJohansson
Copy link
Contributor Author

general note: it should be noted that the server configs override global config.yml

@glensc good point. I'll note that somewhere.

… overriding the sync config in 'config.yml'.
@SebbeJohansson
Copy link
Contributor Author

I added some info on overriding global config right after the example.

@glensc glensc added the documentation Improvements or additions to documentation label Feb 21, 2024
README.md Outdated
trakt_to_plex:
liked_lists: false
```
Only `sync` can be used inside of the config key-value. Keep in mind that the sync-config set in `servers.yml` overrides the global sync-config in `config.yml`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"only sync" is not true either, because other section describes "library" and "excluded-libraries".

perhaps reword as: "sync" section overrides can be used or something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very true. Nice catch. What do you think about: "Using sync in a server config overrides the global sync-config in config.yml." as an alternative?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commited an alternative! Let me know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a point to extended the documentation for this part further. Let me know if you have any ideas.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
SebbeJohansson and others added 4 commits February 22, 2024 12:12
Co-authored-by: Elan Ruusamäe <[email protected]>
Co-authored-by: Elan Ruusamäe <[email protected]>
Co-authored-by: Elan Ruusamäe <[email protected]>
Co-authored-by: Elan Ruusamäe <[email protected]>
@glensc glensc merged commit 027d3ce into Taxel:main Feb 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Config per library
2 participants