-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config added: Per server/library configuration example and instructions. #1814
Conversation
As discussed in: #1808 |
README.md
Outdated
ofelia.job-run.plextraktsync2.container: "plextraktsync" | ||
ofelia.job-run.plextraktsync2.command: "--server 'Example2' sync" | ||
``` | ||
This means that a job is running every 6 hours, alternating between the two "servers". Keep in mind that since this example assumes that you are only running one container, you need to make sure that the jobs don't overlap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why jobs can't overlap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because if the job takes a long time (say over half a second) Ofelia doesn't want to create the same container again. Maybe there is a cleaner way? Not super used to Ofelia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, that just means it runs only one job at a time.
either remove the warning, or explain what it's for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea true. Ive rewritten it and extended it with some further information! Let me know what you think! 😄
general note: it should be noted that the server configs override global config.yml |
@glensc good point. I'll note that somewhere. |
… overriding the sync config in 'config.yml'.
I added some info on overriding global config right after the example. |
README.md
Outdated
trakt_to_plex: | ||
liked_lists: false | ||
``` | ||
Only `sync` can be used inside of the config key-value. Keep in mind that the sync-config set in `servers.yml` overrides the global sync-config in `config.yml`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"only sync" is not true either, because other section describes "library" and "excluded-libraries".
perhaps reword as: "sync" section overrides can be used or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is very true. Nice catch. What do you think about: "Using sync
in a server config overrides the global sync-config in config.yml
." as an alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commited an alternative! Let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be a point to extended the documentation for this part further. Let me know if you have any ideas.
Co-authored-by: Elan Ruusamäe <[email protected]>
Co-authored-by: Elan Ruusamäe <[email protected]>
Co-authored-by: Elan Ruusamäe <[email protected]>
Co-authored-by: Elan Ruusamäe <[email protected]>
Fixes #1808