Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show translations in profile languages #2791

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Commits on May 5, 2021

  1. Only show translations in profile langs by default

    This commit changes the behavior of the expand/collapse
    translations button in the new design. Now, unless a
    particular language is selected in "Show translations in":
    
    - if the user has two profile languages or more, then hide
      non-profile-language translations behind the
      expand/collapse button.
    
    - if the user is logged out or has one profile language or
      less, then keep the existing behavior of only showing the
      first five translations.
    
    This will hopefully show more relevant results by default.
    jiru committed May 5, 2021
    Configuration menu
    Copy the full SHA
    bec94a2 View commit details
    Browse the repository at this point in the history
  2. Simplify json language list

    So that it’s gonna be easier to add custom entries.
    jiru committed May 5, 2021
    Configuration menu
    Copy the full SHA
    36fcb94 View commit details
    Browse the repository at this point in the history
  3. Only show translations in profile langs by default

    This commit changes the behavior of the expand/collapse
    translations button in the old design. Now, unless a
    particular language is selected in "Show translations in":
    
    - if the user has two profile languages or more, then hide
      non-profile-language translations behind the
      expand/collapse button.
    
    - if the user is logged out or has one profile language or
      less, then keep the existing behavior of only showing the
      first five translations.
    
    This will hopefully show more relevant results by default.
    jiru committed May 5, 2021
    Configuration menu
    Copy the full SHA
    3d70ae9 View commit details
    Browse the repository at this point in the history
  4. Rename variable

    This variable counts sentences that are initially
    hidden, so it should be named "hidden" or
    "toDisplay" or similar.
    jiru committed May 5, 2021
    Configuration menu
    Copy the full SHA
    8c77528 View commit details
    Browse the repository at this point in the history
  5. Change translations expand/collapse button label

    Now that this button can hide *all* the
    translations, it would not make sense to make it
    say "show n more translations" in that case.
    
    Also included the icon inside the translatable
    string to allow translators to put it at a
    different place (this should be useful for RTL
    languages).
    jiru committed May 5, 2021
    Configuration menu
    Copy the full SHA
    46c8d6b View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Configuration menu
    Copy the full SHA
    eb8ee3a View commit details
    Browse the repository at this point in the history
  2. Change translations expand/collapse button label

    Apply the same changes as in
    46c8d6b
    on the new design.
    jiru committed May 18, 2021
    Configuration menu
    Copy the full SHA
    010be88 View commit details
    Browse the repository at this point in the history