-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show translations in profile languages #2791
Draft
jiru
wants to merge
7
commits into
dev
Choose a base branch
from
show-translations-in-profile-languages
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on May 5, 2021
-
Only show translations in profile langs by default
This commit changes the behavior of the expand/collapse translations button in the new design. Now, unless a particular language is selected in "Show translations in": - if the user has two profile languages or more, then hide non-profile-language translations behind the expand/collapse button. - if the user is logged out or has one profile language or less, then keep the existing behavior of only showing the first five translations. This will hopefully show more relevant results by default.
Configuration menu - View commit details
-
Copy full SHA for bec94a2 - Browse repository at this point
Copy the full SHA bec94a2View commit details -
So that it’s gonna be easier to add custom entries.
Configuration menu - View commit details
-
Copy full SHA for 36fcb94 - Browse repository at this point
Copy the full SHA 36fcb94View commit details -
Only show translations in profile langs by default
This commit changes the behavior of the expand/collapse translations button in the old design. Now, unless a particular language is selected in "Show translations in": - if the user has two profile languages or more, then hide non-profile-language translations behind the expand/collapse button. - if the user is logged out or has one profile language or less, then keep the existing behavior of only showing the first five translations. This will hopefully show more relevant results by default.
Configuration menu - View commit details
-
Copy full SHA for 3d70ae9 - Browse repository at this point
Copy the full SHA 3d70ae9View commit details -
This variable counts sentences that are initially hidden, so it should be named "hidden" or "toDisplay" or similar.
Configuration menu - View commit details
-
Copy full SHA for 8c77528 - Browse repository at this point
Copy the full SHA 8c77528View commit details -
Change translations expand/collapse button label
Now that this button can hide *all* the translations, it would not make sense to make it say "show n more translations" in that case. Also included the icon inside the translatable string to allow translators to put it at a different place (this should be useful for RTL languages).
Configuration menu - View commit details
-
Copy full SHA for 46c8d6b - Browse repository at this point
Copy the full SHA 46c8d6bView commit details
Commits on May 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for eb8ee3a - Browse repository at this point
Copy the full SHA eb8ee3aView commit details -
Change translations expand/collapse button label
Apply the same changes as in 46c8d6b on the new design.
Configuration menu - View commit details
-
Copy full SHA for 010be88 - Browse repository at this point
Copy the full SHA 010be88View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.