Fix issue when fetching records in all pages #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilla
approved these changes
Mar 17, 2021
swilla
pushed a commit
that referenced
this pull request
Apr 23, 2021
* Add mass update method to client * Change `update` and `patch` methods to support mass update * Use delay between subsequent requests * Update readme * Fix cs * Fix issue when fetching records in all pages (#32) * Support offset in query params * Fix getAllPages() to send handle response with offset correctly Co-authored-by: Yassine Bourakba <[email protected]> * Add mass update method to client * Change `update` and `patch` methods to support mass update * Use delay between subsequent requests * Update readme * Fix cs Co-authored-by: Yassine Bourakba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[issue: #31]
This PR fixes the method
getAllPages()when using filters and the result is paginated.