Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SFML 3 #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChrisThrasher
Copy link

@ChrisThrasher ChrisThrasher commented Jan 3, 2025

This PR fixes all compiler errors with regard to upgrading to the SFML 3 API. Along with the upgrade I took advantage of some new SFML 3 features to streamline code.

Pardon the messy commit history. We'll clean that up later.

- Mark extlibs headers as SYSTEM headers
- Require SFML 2.6
@ChrisThrasher ChrisThrasher changed the base branch from feature/sfml-three to master January 3, 2025 15:33
@ChrisThrasher ChrisThrasher force-pushed the feature/sfml-three branch 6 times, most recently from 776f0c5 to f9794a4 Compare January 3, 2025 16:20
@eXpl0it3r eXpl0it3r force-pushed the feature/sfml-three branch 7 times, most recently from d381842 to 97a10be Compare February 15, 2025 10:07
@eXpl0it3r eXpl0it3r force-pushed the feature/sfml-three branch 4 times, most recently from d777505 to 83c707f Compare February 15, 2025 16:34
Copy link
Collaborator

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done lots of formatting changes and fixed an issue with the install on Windows and it looks like the example still work fine.

Copy link
Author

@ChrisThrasher ChrisThrasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-reviewed every file and fixed a TODO I added during the initial conversion process. This is good to merge now 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants