fix: When using initialRect, the first rendered nodes do not observe ResizeObserver. #816
Conversation
…ResizeObserver Fix to change the reference of instance.measureElement after instance._willUpdate() called so that the ref callback is called again. Refs: TanStack#815
| @@ -47,7 +47,8 @@ function useVirtualizerBase< | |||
| }, []) | |||
|
|
|||
| useIsomorphicLayoutEffect(() => { | |||
| return instance._willUpdate() | |||
| instance._willUpdate() | |||
| instance.measureElement = instance.measureElement.bind(instance) | |||
There was a problem hiding this comment.
Kinda feels like this is more core issue not react specific, hmm what about something like
As we should have elements in cache, we can observe elements when we set scroll element
There was a problem hiding this comment.
Hmm, since this.cleanup() gets called in _willUpdate, this.elementsCache ends up being empty... It seems necessary to call cleanup when this.scrollElement changes, and it feels natural to clear the elementsCache within cleanup, but I can't figure out what the best solution is...
How about making it event-driven and only calling _measureElement after _willUpdate has been called?
I thought so, but it would be better if cleanup() also handled event listeners.
Hmm,I can’t come up with a good idea.
There was a problem hiding this comment.
True, this is bit tricky as when clearing scrollElement we can set it back, but with elementsCache we can't. Kinda feels maybe just stop observing with observer.disconnect() and observe back.
How about making it event-driven and only calling _measureElement after _willUpdate has been called?
When we observe back elements then _measureElement will be called from RO callback.
There was a problem hiding this comment.
Maybe for now let's not clear the cache on clear and observe it back later #830
This fix changes the reference to
instance.measureElementso that the ref callback is called again afterinstance._willUpdate()is called.This PR resolves #815 .