-
-
Notifications
You must be signed in to change notification settings - Fork 404
feat(virtual-core): add skipRemeasurementOnBackwardScroll option to reduce stuttering #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(virtual-core): add skipRemeasurementOnBackwardScroll option to reduce stuttering #1089
Conversation
🦋 Changeset detectedLatest commit: d284d4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dpwls02142 Thanks for the PR, this is addressing a very real problem. I think there are actually two distinct changes here:
I’d strongly suggest splitting these into two separate PRs:
|
…educe stuttering, especially when scrolling lists with dynamically sized items
f14d223 to
d284d4f
Compare
Hi @piecyk, thanks for the detailed feedback! I agree with splitting this into two separate PRs. I'll focus on the backward scroll optimization and remove the batching approach. Changes
About layout stability If an item's size genuinely changed while off-screen, it would get picked up the next time it enters the viewport during normal (non-backward) scrolling. Let me know if you see any issues with this approach! |
🎯 Changes
Batching Scroll Adjustments
pendingAdjustmentDeltasarrayrequestAnimationFrameto batch-apply all adjustments in a single frameBackward Scroll Optimization
disableScrollAdjustmentOnBackwardScrolloption✅ Checklist
pnpm run test:pr.🚀 Release Impact