Defer mobile navbar auth loading - #1110
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesMobile authentication loading
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 148105c | Commit Preview URL Branch Preview URL |
Aug 04 2026, 02:13 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence
PR #1105 added
MobileNavbarAuthControlsinside the mobile menu.CollapsibleContentkeeps its children mounted while closed, so the new lazy component started importing on every page render rather than when the menu opened.The production client graph maps that dynamic path to 10 assets totaling 231,759 uncompressed bytes before cache reuse. Mounting the component also calls
useCurrentUserQuery, so a closed mobile menu could start auth work that the existing desktop navbar intentionally defers until interaction.Follow-up to #1105 and the implementation of #1090.
Change
Keep the existing signed-out link mounted while the mobile menu is closed. Mount
MobileNavbarAuthControlsonly aftermobileMenuOpenbecomes true.Authenticated mobile behavior is unchanged once the menu opens.
Impact
Avoids eager auth chunk loading and current-user query work for visitors who do not open the mobile menu.
Validation
pnpm test— 144 passed, 1 intentional skip; TypeScript and lint cleanpnpm build— passedgit diff --check— passedRisk
Low. The closed menu still renders the same Sign In fallback, and opening the menu preserves the existing Suspense fallback while auth state loads.
Summary by CodeRabbit