Skip to content

Fix text contrast in menu elements #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nicolapps wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −5
Open

Fix text contrast in menu elements #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/MegaMenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ export function MegaMenuItem({
{/* Rest = neutral tint (Figma neutral/tint/200); brightens to
text-primary on hover. Plain string (not twMerge) so the DS size
utility and the color utilities coexist. */}
<span className="font-ds-display text-ds-heading-5 whitespace-nowrap text-text-menu-title transition-colors group-hover/mmi:text-text-primary group-active/mmi:text-text-primary">
<span
className={`font-ds-display text-ds-heading-5 whitespace-nowrap ${variant === 'mobile' ? 'text-ds-neutral-tint-200' : 'text-text-menu-title'} transition-colors group-hover/mmi:text-text-primary group-active/mmi:text-text-primary`}
>
{title}
</span>
{badge ? (
Expand Down
14 changes: 10 additions & 4 deletions src/components/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,9 @@ function MegaMenuContent({
variant === 'mobile' && sectionIndex > 0 && 'pt-3',
)}
>
<div className="mb-2 px-2 font-ds-mono text-ds-mono-sm uppercase text-ds-neutral-100">
<div
className={`mb-2 px-2 font-ds-mono text-ds-mono-sm uppercase ${variant === 'mobile' ? 'text-ds-neutral-100' : 'text-ds-neutral-300 dark:text-ds-neutral-100'}`}
>
{section.label}
</div>
<div
Expand Down Expand Up @@ -1289,7 +1291,9 @@ function BlogMenuContent({
)}
>
<section>
<div className="mb-3 px-1 font-ds-mono text-ds-mono-xs uppercase tracking-wider text-ds-neutral-100">
<div
className={`mb-3 px-1 font-ds-mono text-ds-mono-xs uppercase tracking-wider ${variant === 'mobile' ? 'text-ds-neutral-100' : 'text-ds-neutral-300 dark:text-ds-neutral-100'}`}
>
Blog &amp; Release Notes
</div>
<div
Expand Down Expand Up @@ -1327,7 +1331,9 @@ function BlogMenuContent({

{aboutSection && aboutSection.items.length > 0 ? (
<section className="border-t border-border-subtle pt-4">
<div className="mb-2 px-1 font-ds-mono text-ds-mono-xs uppercase tracking-wider text-ds-neutral-100">
<div
className={`mb-2 px-1 font-ds-mono text-ds-mono-xs uppercase tracking-wider ${variant === 'mobile' ? 'text-ds-neutral-100' : 'text-ds-neutral-300 dark:text-ds-neutral-100'}`}
>
{aboutSection.label}
</div>
<div
Expand Down Expand Up @@ -1563,7 +1569,7 @@ function MenuRail({
<div className="flex flex-col items-start gap-2.5">
{/* "Work with" + the TanStack lockup read together as "Work with
TanStack" (Figma: terracotta/200 label above the landscape mark). */}
<div className="font-ds-display text-base font-normal text-ds-terracotta-200">
<div className="font-ds-display text-base font-normal text-ds-terracotta-400 dark:text-ds-terracotta-200">
{rail.title}
</div>
<img
Expand Down