refactor(*): migrate deprecated phosphor icon names to 'Icon' suffix - #1094
Open
sukvvon wants to merge 2 commits into
Open
refactor(*): migrate deprecated phosphor icon names to 'Icon' suffix#1094sukvvon wants to merge 2 commits into
sukvvon wants to merge 2 commits into
Conversation
|
Important Review skippedToo many files! This PR contains 181 files, which is 31 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (181)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sukvvon
changed the title
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 6ca0670 | Commit Preview URL Branch Preview URL |
Aug 02 2026, 03:07 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@phosphor-icons/reactv2.1.10 marks every unsuffixed export as@deprecatedin favor of its*Iconcounterpart (e.g.Star→StarIcon). Both names resolve to the same component, so this is a rename with no runtime behavior change — it clears the deprecation strikethrough in editors and stops new code from picking up the old names.Changes
180 files — rewrote imports from
@phosphor-icons/reactand their usage sites to the*Iconexports. Aliased imports keep their local name (Sparkle as Sparkles→SparkleIcon as Sparkles).scripts/generate-phosphor-icon-registry.mjs— imports the suffixed export for every icon. This also drops theInfinityspecial case, which existed only because the bare name collides with the JS global;InfinityIconnever does.src/components/ds/phosphor-icons.generated.ts— regenerated from the updated script rather than hand-edited.src/routes/ds.iconography.lazy.tsx— the icon browser copied<Acorn />to the clipboard. The registry keys icons by their bare name, so the copy string and tooltip now appendIconto match what callers actually import. Search and the visible grid labels still use the bare name.Inline
code={...}examples on theds/*pages were updated as well, so the JSX shown on the page matches the supported import.Notes
Icon names that collide with unrelated components (
Link,Table,Spinner,Command,User) were left alone where they resolve to something other than Phosphor — only identifiers imported from@phosphor-icons/reactwere touched.