Skip to content

Scope Intent registry loader dependencies - #1092

Open
tannerlinsley wants to merge 1 commit into
mainfrom
agent/scope-intent-registry-loader-deps
Open

Scope Intent registry loader dependencies#1092
tannerlinsley wants to merge 1 commit into
mainfrom
agent/scope-intent-registry-loader-deps

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Aug 2, 2026

Copy link
Copy Markdown
Member

What changed

Narrow the Intent registry route loader dependencies to the four search values the loader actually consumes: q, framework, sort, and page.

Evidence and impact

The route previously returned the entire validated search object from loaderDeps. Changing client-only tab or view state therefore invalidated the loader and reran its stats and directory query checks even though neither value is read by the loader.

This follows the repository's TanStack guidance that loader dependencies include only values used by the loader. Package search, framework filtering, sorting, and pagination still invalidate it as before.

Validation

  • pnpm test
  • TypeScript clean
  • oxlint clean
  • 143 tests passed; 1 environment-gated docs smoke test skipped
  • Commit hook reran formatting and the full test gate successfully
  • git diff --check

Risk

Low. The change only removes two unused loader dependencies. Both values remain validated URL state and continue to drive client rendering and skill search.

Summary by CodeRabbit

  • Bug Fixes
    • Improved search result updates by responding only to relevant filters, sorting, and pagination changes.
    • Prevented unrelated URL parameter changes from triggering unnecessary reloads.

@tannerlinsley tannerlinsley added the source-audit Tracked by the automated source audit label Aug 2, 2026
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 97063b61-70a6-4e5c-98eb-51294662cadd

📥 Commits

Reviewing files that changed from the base of the PR and between 750479b and ae3a1c8.

📒 Files selected for processing (1)
  • src/routes/intent/registry/index.tsx

📝 Walkthrough

Walkthrough

The registry route loader now derives dependencies from only the relevant search parameters: q, framework, sort, and page.

Changes

Registry loader dependencies

Layer / File(s) Summary
Constrain loader dependencies
src/routes/intent/registry/index.tsx
loaderDeps now returns only q, framework, sort, and page instead of the complete search state.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: limiting Intent registry loader dependencies to relevant search parameters.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/scope-intent-registry-loader-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com ae3a1c8 Commit Preview URL

Branch Preview URL
Aug 02 2026, 03:14 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source-audit Tracked by the automated source audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant