Scope Intent registry loader dependencies - #1092
Open
tannerlinsley wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe registry route loader now derives dependencies from only the relevant search parameters: ChangesRegistry loader dependencies
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | ae3a1c8 | Commit Preview URL Branch Preview URL |
Aug 02 2026, 03:14 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Narrow the Intent registry route loader dependencies to the four search values the loader actually consumes:
q,framework,sort, andpage.Evidence and impact
The route previously returned the entire validated search object from
loaderDeps. Changing client-onlytaborviewstate therefore invalidated the loader and reran its stats and directory query checks even though neither value is read by the loader.This follows the repository's TanStack guidance that loader dependencies include only values used by the loader. Package search, framework filtering, sorting, and pagination still invalidate it as before.
Validation
pnpm testgit diff --checkRisk
Low. The change only removes two unused loader dependencies. Both values remain validated URL state and continue to drive client rendering and skill search.
Summary by CodeRabbit